Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed to get afg sub nodes on ChromeOS devices #1642

Closed
kv2019i opened this issue Dec 19, 2019 · 12 comments
Closed

failed to get afg sub nodes on ChromeOS devices #1642

kv2019i opened this issue Dec 19, 2019 · 12 comments
Assignees
@kv2019i
Labels
bug Something isn't working Chrome Related to Chrome integration GLK Applies to Gemini Lake HDA Applies to HD-Audio bus for codec connection JSL Jasper Lake platform issues P2 Critical bugs or normal features TGL Applies to Tiger Lake platform

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 19, 2019

Multiple sightings have been reported of failure to probe the HDMI codec in i915 at boot, specifically on ChromeOS devices and a recent 5.4/5.5 kernel.

Error logs:
[ 79.756783] snd_hda_codec_hdmi ehdaudio0D2: HDMI: failed to get afg sub nodes
[ 79.756800] snd_hda_codec_hdmi ehdaudio0D2: patch failed -22
[ 79.756862] snd_hda_codec_hdmi ehdaudio0D2: ASoC: failed to probe
component -22
[ 79.756930] bxt_da7219_max98357a glk_da7219_max98357a: ASoC: failed
to instantiate card -22
...
[ 79.769445] bxt_da7219_max98357a: probe of glk_da7219_max98357a failed with error -22

Fixes to #1001 , #1183 and #1374 do not help as e.g. 5.5-rc1 has all the fixes included and the error still happens.
@kv2019i kv2019i added bug Something isn't working GLK Applies to Gemini Lake Chrome Related to Chrome integration JSL Jasper Lake platform issues labels Dec 19, 2019
@kv2019i kv2019i self-assigned this Dec 19, 2019
@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 19, 2019

FYI @yongzhi1 and @cujomalainey
I've still not been able to reproduce this myself on any device (including a GLK device running ChromeOS, but will continue to try ith this one). As it seems we have to gather sightings and data from a larger set of devices, filing a bug for tracking.

@kv2019i kv2019i added the HDA Applies to HD-Audio bus for codec connection label Dec 19, 2019
@kv2019i
Copy link
Collaborator Author

kv2019i commented Dec 30, 2019

@yongzhi1 and @cujomalainey -- I've now reproduced the issue on a GLK Chromebook using a kernel module load-unload stress test.

Flow-wise there is nothing wrong in the sequence, but I did notice a slight difference between legacy-HDA and SOF drivers. If I add an extra GET_PARAMETERS HDA verb to the SOF flow (right after power-up) to imitate what happens with legacy HDA driver, the errors are gone. I'll continue investigating (why this flow change helps and how to turn it into a upstream-acceptable fix).

kv2019i added a commit to kv2019i/linux that referenced this issue Jan 3, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to hdmi_parse_codec
4685d86 
The initial snd_hda_get_sub_node() can sometimes fail on
certain Intel devices (e.g. some GLK Chromebook models).

Add retry logic to sub node query. Based on stress testing,
this can overcome the problem on all known cases and does
not impact other platforms.

Change-Id: I6c78e2eaaa900ecb7a6ea77dff6e62287e697dc4
BugLink: thesofproject#1642
@kv2019i
Copy link
Collaborator Author

kv2019i commented Jan 3, 2020

I uploaded a potential bugfix at:
kv2019i@4685d86
https://github.com/kv2019i/linux/tree/topic/cras/l5.4-glk-hdmi-afg-fix

@cujomalainey
Copy link
Member

Been trying to bisect this but failures go back pretty far. Your branch by itself is fine.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Jan 10, 2020

It seems the above fix does not work on all Bobba devices. I posted a 2nd experimental patch to the above branch:
kv2019i@b3c8d21
https://github.com/kv2019i/linux/tree/topic/cras/l5.4-glk-hdmi-afg-fix
... waiting to gather more data whether this helps. Still no signs of this issue in CI or from other reporters.

@cujomalainey
Copy link
Member

cujomalainey commented Jan 10, 2020 •
edited
Loading

@kv2019i probe works with that second patch and I get devices 😺

I cherry-picked over the top 2 commits to sof-dev and I have playback again. Thanks so much.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Jan 13, 2020

@cujomalainey wrote

@kv2019i probe works with that second patch and I get devices 😺

I cherry-picked over the top 2 commits to sof-dev and I have playback again. Thanks so much.

Excellent! 😎 I'll start working out an upstream-worthy patchset. 2nd patch should be easy, but first one may require some more effort to get through.

@kv2019i kv2019i self-assigned this Jan 14, 2020
kv2019i added a commit to kv2019i/linux that referenced this issue Jan 15, 2020
@kv2019i
ASoC: SOF: Intel: do not disable i915 during probe
acca9e4 
Change HDA probe behaviour slightly so that i915 power is not
turned off if i915 codecs are found in the initial probe done by
SOF Intel driver, and power is kept on until HDA codec driver probe
runs.

This will reduce number of mode sets on platforms with low
minimum CDCLK (like GLK) and brings the SOF probe sequence closer
to legacy HDA driver in terms of i915 audio codec power management.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i added a commit to kv2019i/linux that referenced this issue Jan 15, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
c7fbaf8 
The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i mentioned this issue Jan 15, 2020
Closed
@kv2019i kv2019i added the P2 Critical bugs or normal features label Jan 15, 2020
kv2019i added a commit to kv2019i/linux that referenced this issue Jan 16, 2020
@kv2019i
ASoC: SOF: Intel: do not disable i915 during probe
bfb0672 
Change HDA probe behaviour slightly so that i915 power is not
turned off if i915 codecs are found in the initial probe done by
SOF Intel driver, and power is kept on until HDA codec driver probe
runs.

This will reduce number of mode sets on platforms with low
minimum CDCLK (like GLK) and brings the SOF probe sequence closer
to legacy HDA driver in terms of i915 audio codec power management.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i added a commit to kv2019i/linux that referenced this issue Jan 16, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
c36eb16 
The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jan 17, 2020
@kv2019i @intel-lab-lkp
ASoC: SOF: Intel: do not disable i915 power during probe
7273e26 
Change HDA probe behaviour slightly so that i915 power is not
turned off if i915 audio codecs are found in the initial probe done
by SOF Intel driver, and power is kept on until HDA codec driver
probe runs.

This will reduce number of mode sets on platforms with low
minimum CDCLK (like GLK) and brings the SOF probe sequence closer
to legacy HDA driver in terms of i915 audio codec power management.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jan 17, 2020
@kv2019i @intel-lab-lkp
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
a38d644 
The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i added a commit to kv2019i/linux that referenced this issue Jan 17, 2020
@kv2019i
ASoC: SOF: Intel: do not disable i915 power during probe
418da26 
Change HDA probe behaviour slightly so that i915 power is not
turned off if i915 audio codecs are found in the initial probe done
by SOF Intel driver, and power is kept on until HDA codec driver
probe runs.

This will reduce number of mode sets on platforms with low
minimum CDCLK (like GLK) and brings the SOF probe sequence closer
to legacy HDA driver in terms of i915 audio codec power management.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i added a commit to kv2019i/linux that referenced this issue Jan 17, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
773f510 
The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
tiwai pushed a commit to tiwai/sound that referenced this issue Jan 20, 2020
@kv2019i @tiwai
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
15c0d83 
The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
FireBurn pushed a commit to FireBurn/linux that referenced this issue Jan 21, 2020
@kv2019i @tiwai
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
2928fa0 
The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
@sathya-nujella sathya-nujella added TGL Applies to Tiger Lake platform and removed TGL Applies to Tiger Lake platform labels Jan 25, 2020
frank-w pushed a commit to frank-w/BPI-Router-Linux that referenced this issue Mar 21, 2020
@kv2019i @frank-w
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
5dfd2f9 
[ Upstream commit 2928fa0 ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kartikbhalla12 pushed a commit to kartikbhalla12/HyperX-X2 that referenced this issue Apr 4, 2020
@kv2019i @kartikbhalla12
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
d1dcf34 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/linux-mvista that referenced this issue Apr 7, 2020
@kv2019i @mvakuster
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
af0efcd 
Source: Kernel.org
MR: 102918
Type: Security Fix
Disposition: Backport from git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable linux-4.14.y
ChangeID: 02b675041fcd930fd7d95b4e7bb68ddea4b21d9e
Description:

[ Upstream commit 2928fa0 ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Armin Kuster <akuster@mvista.com>
jpuhlman pushed a commit to MontaVista-OpenSourceTechnology/linux-mvista that referenced this issue Apr 7, 2020
@kv2019i @mvakuster
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
439490c 
Source: Kernel.org
MR: 102901
Type: Security Fix
Disposition: Backport from git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable linux-4.19.y
ChangeID: afdf4de910986e50567c92b9e4ff901606013978
Description:

[ Upstream commit 2928fa0 ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Armin Kuster <akuster@mvista.com>
VyattaInternal pushed a commit to danos/linux-vyatta that referenced this issue Apr 8, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
671f4cb 
[ Upstream commit 2928fa0 ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
jackpot51 pushed a commit to pop-os/linux that referenced this issue Apr 13, 2020
@kv2019i @kelmously
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
76821b8 
BugLink: https://bugs.launchpad.net/bugs/1868324

[ Upstream commit 2928fa0 ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
freesky-edward pushed a commit to openeuler-mirror/kernel that referenced this issue Apr 18, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
bf0dca0 
[ Upstream commit 2928fa0 ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
mseaster-wr pushed a commit to WindRiver-Labs/linux-yocto-5.2 that referenced this issue Jun 10, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
57873d0 
commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a upstream.

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Dark98 pushed a commit to moto-sm6xxx/android_kernel_motorola_trinket that referenced this issue Jul 14, 2020
@kv2019i @Dark98
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
106c78d 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
danielgusvt pushed a commit to danielgusvt/android_kernel_motorola_trinket that referenced this issue Jul 18, 2020
@kv2019i @danielgusvt
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
ca87bae 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
RenderBroken pushed a commit to RenderBroken/op7-kernel that referenced this issue Aug 6, 2020
@kv2019i @RenderBroken
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
7c587d2 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Aug 14, 2020
@kv2019i @miraclestars
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
23334de 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Aug 14, 2020
@kv2019i @miraclestars
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
781da51 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
miraclestars pushed a commit to miraclestars/android_kernel_samsung_sm8250 that referenced this issue Aug 14, 2020
@kv2019i @miraclestars
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
7d67f12 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Claymore1297 pushed a commit to Claymore1297/kernel_oneplus_sm8150 that referenced this issue Aug 17, 2020
@kv2019i @Claymore1297
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
a7c1c9c 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
KenHV pushed a commit to KenHV/kensur_kernel_liber that referenced this issue Oct 5, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
0e89f91 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
KenHV pushed a commit to KenHV/kensur_kernel_liber that referenced this issue Oct 6, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
f196806 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
KenHV pushed a commit to KenHV/kensur_kernel_liber that referenced this issue Oct 7, 2020
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
080350c 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ThunderStorms21th pushed a commit to ThunderStorms21th/Galaxy-S10 that referenced this issue Mar 24, 2021
@kv2019i @ThunderStorms21th
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
33ec27f 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
soulr344 pushed a commit to TotsukaINC/android_kernel_universal_my1nsxx that referenced this issue May 5, 2021
@kv2019i @soulr344
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
63bf5b3 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
TenSeventy7 pushed a commit to FreshROMs/android_kernel_samsung_exynos9610_mint that referenced this issue May 15, 2021
@kv2019i @TenSeventy7
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
97c6f29 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
TenSeventy7 pushed a commit to FreshROMs/android_kernel_samsung_exynos9610_mint that referenced this issue May 19, 2021
@kv2019i @TenSeventy7
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
e0d92fe 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sergoops pushed a commit to sergoops/kernel_realme_sm6150 that referenced this issue Aug 31, 2021
@kv2019i @sergoops
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
6736c85 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
krazey pushed a commit to krazey/android_kernel_motorola_exynos9610 that referenced this issue May 5, 2022
@kv2019i @krazey
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
0dcb228 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
krazey pushed a commit to krazey/android_kernel_motorola_exynos9610 that referenced this issue May 5, 2022
@kv2019i @krazey
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
e2599d8 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
GiovanYCringe pushed a commit to GiovanYCringe-Experiments/kernel_a50 that referenced this issue Jul 3, 2023
@kv2019i
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
d848a1b 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: John Vincent <git@tensevntysevn.cf>
Signed-off-by: John Vincent <git@tenseventyseven.cf>
Meghthedev pushed a commit to Meghthedev/kernel_samsung_m30s that referenced this issue Jul 20, 2023
@kv2019i @Meghthedev
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
a4b8d50 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Meghthedev pushed a commit to Meghthedev/kernel_samsung_m30s that referenced this issue Jul 20, 2023
@kv2019i @Meghthedev
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
84ebb86 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Meghthedev pushed a commit to Meghthedev/kernel_samsung_m30s that referenced this issue Aug 25, 2023
@kv2019i @Meghthedev
ALSA: hda/hdmi - add retry logic to parse_intel_hdmi()
5b257e0 
[ Upstream commit 2928fa0a97ebb9549cb877fdc99aed9b95438c3a ]

The initial snd_hda_get_sub_node() can fail on certain
devices (e.g. some Chromebook models using Intel GLK).
The failure rate is very low, but as this is is part of
the probe process, end-user impact is high.

In observed cases, related hardware status registers have
expected values, but the node query still fails. Retrying
the node query does seem to help, so fix the problem by
adding retry logic to the query. This does not impact
non-Intel platforms.

BugLink: thesofproject/linux#1642
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200120160117.29130-4-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kv2019i kv2019i

Labels
bug Something isn't working Chrome Related to Chrome integration GLK Applies to Gemini Lake HDA Applies to HD-Audio bus for codec connection JSL Jasper Lake platform issues P2 Critical bugs or normal features TGL Applies to Tiger Lake platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix to GLK Chrome HDMI probe error kv2019i/linux
4 participants
@cujomalainey @ranj063 @kv2019i @sathya-nujella