Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace init failed #189

Closed
ZhendanYang opened this issue Oct 17, 2018 · 2 comments · Fixed by #190
Closed

Trace init failed #189

ZhendanYang opened this issue Oct 17, 2018 · 2 comments · Fixed by #190
Assignees
@keyonjie
Labels
APL Applies to ApolloLake platform bug Something isn't working P1 Blocker bugs or important features

Comments

@ZhendanYang
Copy link

Summary:
[ 97.249675] sof-audio sof-audio: Firmware info: version 1.1-b9717 build 43 on Oct 16 2018:21:24:56
[ 97.249768] sof-audio sof-audio: found ext header type 1 size 0x9c
[ 97.249783] sof-audio sof-audio: booting DSP firmware completed
[ 97.249788] sof-audio sof-audio: ipc rx done: 0x70000000
[ 97.256163] sof-audio sof-audio: Firmware download successful, booting...
[ 97.256171] sof-audio sof-audio: firmware boot complete
[ 97.256310] sof-audio sof-audio: generating page table for 000000003e4a4c6c size 0x10000 pages 16
[ 97.256316] sof-audio sof-audio: pfn i 0 idx 0 pfn 16cd00
[ 97.256322] sof-audio sof-audio: pfn i 1 idx 2 pfn 16cd01
[ 97.256327] sof-audio sof-audio: pfn i 2 idx 5 pfn 16cd02
[ 97.256332] sof-audio sof-audio: pfn i 3 idx 7 pfn 16cd03
[ 97.256337] sof-audio sof-audio: pfn i 4 idx 10 pfn 16cd04
[ 97.256342] sof-audio sof-audio: pfn i 5 idx 12 pfn 16cd05
[ 97.256347] sof-audio sof-audio: pfn i 6 idx 15 pfn 16cd06
[ 97.256352] sof-audio sof-audio: pfn i 7 idx 17 pfn 16cd07
[ 97.256357] sof-audio sof-audio: pfn i 8 idx 20 pfn 16cd08
[ 97.256362] sof-audio sof-audio: pfn i 9 idx 22 pfn 16cd09
[ 97.256367] sof-audio sof-audio: pfn i 10 idx 25 pfn 16cd0a
[ 97.256373] sof-audio sof-audio: pfn i 11 idx 27 pfn 16cd0b
[ 97.256378] sof-audio sof-audio: pfn i 12 idx 30 pfn 16cd0c
[ 97.256383] sof-audio sof-audio: pfn i 13 idx 32 pfn 16cd0d
[ 97.256388] sof-audio sof-audio: pfn i 14 idx 35 pfn 16cd0e
[ 97.256393] sof-audio sof-audio: pfn i 15 idx 37 pfn 16cd0f
[ 97.256398] sof-audio sof-audio: dma_trace_pages: 16
[ 97.256414] sof-audio sof-audio: error: cannot create debugfs entry for trace
[ 97.256433] sof-audio sof-audio: warning: failed to init trace after resume -19

Test env:
sof-master: b971739
soft-master: 5b51dc0
kernel sof-dev: bf67a28
kernel commit 93853cb has no such issue.
@ZhendanYang ZhendanYang added bug Something isn't working APL Applies to ApolloLake platform labels Oct 17, 2018
@keyonjie keyonjie self-assigned this Oct 17, 2018
@mengdonglin
Copy link
Collaborator

@ZhendanYang Can this issue be reproduced by kernel commit ASoC: SOF: set up memory windows only at first boot …?
2a28aca

@mengdonglin mengdonglin added the P1 Blocker bugs or important features label Oct 17, 2018
@keyonjie keyonjie mentioned this issue Oct 17, 2018
Merged
@keyonjie
Copy link

this should be fixed by #190

aiChaoSONG pushed a commit to aiChaoSONG/linux that referenced this issue May 6, 2021
@ojeda
Merge pull request thesofproject#189 from ojeda/eof-typo
b6f20e7 
Remove blank line at EOF
Vamshigopal pushed a commit to Vamshigopal/linux that referenced this issue Jan 24, 2023
@gregkh
scsi: mpt3sas: Fix possible resource leaks in mpt3sas_transport_port_…
ce1a69c 
…add()

[ Upstream commit 78316e9 ]

In mpt3sas_transport_port_add(), if sas_rphy_add() returns error,
sas_rphy_free() needs be called to free the resource allocated in
sas_end_device_alloc(). Otherwise a kernel crash will happen:

Unable to handle kernel NULL pointer dereference at virtual address 0000000000000108
CPU: 45 PID: 37020 Comm: bash Kdump: loaded Tainted: G        W          6.1.0-rc1+ thesofproject#189
pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : device_del+0x54/0x3d0
lr : device_del+0x37c/0x3d0
Call trace:
 device_del+0x54/0x3d0
 attribute_container_class_device_del+0x28/0x38
 transport_remove_classdev+0x6c/0x80
 attribute_container_device_trigger+0x108/0x110
 transport_remove_device+0x28/0x38
 sas_rphy_remove+0x50/0x78 [scsi_transport_sas]
 sas_port_delete+0x30/0x148 [scsi_transport_sas]
 do_sas_phy_delete+0x78/0x80 [scsi_transport_sas]
 device_for_each_child+0x68/0xb0
 sas_remove_children+0x30/0x50 [scsi_transport_sas]
 sas_rphy_remove+0x38/0x78 [scsi_transport_sas]
 sas_port_delete+0x30/0x148 [scsi_transport_sas]
 do_sas_phy_delete+0x78/0x80 [scsi_transport_sas]
 device_for_each_child+0x68/0xb0
 sas_remove_children+0x30/0x50 [scsi_transport_sas]
 sas_remove_host+0x20/0x38 [scsi_transport_sas]
 scsih_remove+0xd8/0x420 [mpt3sas]

Because transport_add_device() is not called when sas_rphy_add() fails, the
device is not added. When sas_rphy_remove() is subsequently called to
remove the device in the remove() path, a NULL pointer dereference happens.

Fixes: f92363d ("[SCSI] mpt3sas: add new driver supporting 12GB SAS")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221109032403.1636422-1-yangyingliang@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keyonjie keyonjie

Labels
APL Applies to ApolloLake platform bug Something isn't working P1 Blocker bugs or important features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ASoC: SOF: fix trace resume fails issue keyonjie/linux
3 participants
@mengdonglin @keyonjie @ZhendanYang