Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDW][]BUG][CML-H]Dmesg shows "sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22 " when system boot up successfully. #2031

Closed
sinahuang opened this issue Apr 21, 2020 · 8 comments
Closed

[SDW][]BUG][CML-H]Dmesg shows "sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22 " when system boot up successfully. #2031

sinahuang opened this issue Apr 21, 2020 · 8 comments
Labels
bug Something isn't working CML Applies to Comet Lake platform P1 Blocker bugs or important features SDW Applies to SoundWire bus for codec connection

Comments

@sinahuang
Copy link

Describe the bug
Aplay -l display "no soundcard" when dmesg shows "sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22 ".

To Reproduce
1.Boot up system successfully.
2.Aplay -l and then check dmesg.

Reproduce rate
5/5

Expected result
No error display after booting up successfully.

Actual result
Dmesg shows "sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22 ".

[    3.200397] sof_sdw sof_sdw: rt711-aif1 <-> SDW0 Pin2 mapping ok
[    3.200401] sof_sdw sof_sdw: rt711-aif1 <-> SDW0 Pin3 mapping ok
[    3.200432]  SDW1-Playback: DPCM doesn't support Multi CPU yet
[    3.200436] sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22
[    3.200931] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x1010f0f successful
[    3.200938] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x1000f0f successful
[    3.200941] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.200950] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.200957] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.200960] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.200968] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.200974] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.200977] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.200985] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.200992] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.200995] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.201003] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201009] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201011] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.201015] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201021] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201023] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.201028] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201031] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201033] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.201038] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201042] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[    3.201044] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask 1
[    3.201247] sof_sdw sof_sdw: snd_soc_register_card failed -22
[    3.201254] sof_sdw: probe of sof_sdw failed with error -22
[    3.236699] scsi 0:0:0:0: Direct-Access     Generic  MassStorageClass 1536 PQ: 0 ANSI: 6
[    3.236834] sd 0:0:0:0: Attached scsi generic sg0 type 0
[    3.442642] scsi 0:0:0:1: Direct-Access     Generic  MassStorageClass 1536 PQ: 0 ANSI: 6
[    3.442760] sd 0:0:0:1: Attached scsi generic sg1 type 0
[    3.465982] buggy seq_file .next function proc_keys_next did not updated position index
[    3.648735] sd 0:0:0:0: [sda] Attached SCSI removable disk
[    3.859688] sd 0:0:0:1: [sdb] Attached SCSI removable disk
[    4.005009] scsi 1:0:0:0: Direct-Access     Kingston DataTraveler 2.0 PMAP PQ: 0 ANSI: 6
[    4.005275] sd 1:0:0:0: Attached scsi generic sg2 type 0
[    4.005640] sd 1:0:0:0: [sdc] 30240768 512-byte logical blocks: (15.5 GB/14.4 GiB)
[    4.005929] sd 1:0:0:0: [sdc] Write Protect is off
[    4.005931] sd 1:0:0:0: [sdc] Mode Sense: 45 00 00 00
[    4.006185] sd 1:0:0:0: [sdc] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
[    4.021266]  sdc: sdc1
[    4.023219] sd 1:0:0:0: [sdc] Attached SCSI removable disk
[    5.538656] FAT-fs (sdc1): Volume was not properly unmounted. Some data may be corrupt. Please run fsck.
[    5.687935] rfkill: input handler disabled
[    8.226307] intel-master sdw-master-1: IO transfer timed out, cmd 3 device 1 addr 45 len 1
[    8.226312] intel-master sdw-master-1: trf on Slave 1 failed:-110
[    8.226314] rt1308 sdw:1:25d:1308:0: Clock Stop prepare failed for slave: -110
[    8.226315] rt1308 sdw:1:25d:1308:0: pre-prepare failed:-110
[    8.226316] intel-master sdw-master-1: prepare clock stop failed -110
[    8.226317] intel-master sdw-master-1: cannot enable clock stop on suspend
[    8.226322] intel-master sdw-master-2: IO transfer timed out, cmd 3 device 1 addr 45 len 1
[    8.226323] intel-master sdw-master-2: trf on Slave 1 failed:-110
[    8.226324] rt1308 sdw:2:25d:1308:0: Clock Stop prepare failed for slave: -110
[    8.226326] rt1308 sdw:2:25d:1308:0: pre-prepare failed:-110
[    8.226327] intel-master sdw-master-2: prepare clock stop failed -110
[    8.226328] intel-master sdw-master-2: cannot enable clock stop on suspend
[    8.226332] intel-master sdw-master-3: IO transfer timed out, cmd 3 device 1 addr 45 len 1
[    8.226333] intel-master sdw-master-3: trf on Slave 1 failed:-110
[    8.226335] rt715 sdw:3:25d:715:0: Clock Stop prepare failed for slave: -110
[    8.226336] rt715 sdw:3:25d:715:0: pre-prepare failed:-110

Test recipe

Kernel:https://github.com/thesofproject/linux/commits/topic/sof-dev commit:f17b96ae
FW: https://github.com/thesofproject/sof/commits/master commit: 504ec4
Tplg: Same with FW branch, sof-cml-rt711-rt1308-rt715.tplg
Platform:CML-H Laptop with codec ALC711, 2 x RT1308, RT715 in SDW mode.

dmesg21.log
@sinahuang sinahuang added bug Something isn't working CML Applies to Comet Lake platform SDW Applies to SoundWire bus for codec connection labels Apr 21, 2020
@sinahuang
Copy link
Author

sinahuang commented Apr 21, 2020 •
edited
Loading

I tried it with kernel on ww16.5( top commit:f9b8747), this issue can't be reproduced. But I found this commit seems replaced by commit:18aaab6 , but the SOF can't load up successfully with it.

@bardliao
Copy link
Collaborator

It is due to 9b5db05.

@plbossart
Copy link
Member

Are you sure @bardliao ? we already define the min_channels in intel_create_dai():

		if (type == INTEL_PDI_BD || type == INTEL_PDI_OUT) {
			dais[i].playback.channels_min = 1;
			dais[i].playback.channels_max = max_ch;
			dais[i].playback.rates = SNDRV_PCM_RATE_48000;
			dais[i].playback.formats = SNDRV_PCM_FMTBIT_S16_LE;
		}

		if (type == INTEL_PDI_BD || type == INTEL_PDI_IN) {
			dais[i].capture.channels_min = 1;
			dais[i].capture.channels_max = max_ch;
			dais[i].capture.rates = SNDRV_PCM_RATE_48000;
			dais[i].capture.formats = SNDRV_PCM_FMTBIT_S16_LE;
		}

So I am not sure what the addition of the new tests in 9b5db05 would change?

@bardliao
Copy link
Collaborator

@plbossart Yes, if (rtd->num_cpus > 1) test is failed.
[ 3.200432] SDW1-Playback: DPCM doesn't support Multi CPU yet
That is a new test in 9b5db05 and I verified with my CML-H laptop

@sinahuang sinahuang changed the title [SDW][]BUG][CML-H]Dmesg shows "sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22 " when system booting up successfully. [SDW][]BUG][CML-H]Dmesg shows "sof_sdw sof_sdw: ASoC: can't create pcm SDW1-Playback :-22 " when system boot up successfully. Apr 22, 2020
@sinahuang
Copy link
Author

Tried it with latest sof-dev after reverting commit:9b5db05, issue can't be reproduced. Issue might be caused by this commit.

@ClarexZhou ClarexZhou added the P1 Blocker bugs or important features label Apr 26, 2020
plbossart added a commit to plbossart/sound that referenced this issue Apr 27, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
920a436 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart plbossart mentioned this issue Apr 27, 2020
Merged
@plbossart
Copy link
Member

@sinahuang can you try with PR #2058 ?

@sinahuang
Copy link
Author

Check this issue with sof-dev (commit:8f1c6ad) +PR #2058, error can't be seen.

plbossart added a commit to plbossart/sound that referenced this issue Apr 28, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
c32ff05 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Apr 28, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
8f9cf9c 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@sinahuang sinahuang mentioned this issue Apr 29, 2020
Closed
ranj063 pushed a commit that referenced this issue Apr 29, 2020
@plbossart @ranj063
ASoC: soc-pcm: dpcm: fix playback/capture checks
f97d55a 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Apr 29, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
b0be925 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Apr 29, 2020
@plbossart
fixup! ASoC: soc-pcm: dpcm: fix playback/capture checks
db35317 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart plbossart mentioned this issue Apr 29, 2020
Merged
@ClarexZhou
Copy link

Close for error not seen on sof dev commit 5278d5d, after PR #2058 is merged.

plbossart added a commit that referenced this issue Apr 30, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
aedf86e 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
plbossart added a commit that referenced this issue May 1, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
782f3a4 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit to kv2019i/linux that referenced this issue May 12, 2020
@plbossart @kv2019i
ASoC: soc-pcm: dpcm: fix playback/capture checks
0ea3b7d 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit to kv2019i/linux that referenced this issue May 12, 2020
@plbossart @kv2019i
ASoC: soc-pcm: dpcm: fix playback/capture checks
a7127de 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit that referenced this issue May 15, 2020
@plbossart @kv2019i
ASoC: soc-pcm: dpcm: fix playback/capture checks
bd2d135 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue May 20, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
6401679 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
kv2019i pushed a commit that referenced this issue May 25, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
d777ee6 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue May 26, 2020
@plbossart
fixup! ASoC: soc-pcm: dpcm: fix playback/capture checks
4fb042b 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue May 28, 2020
@plbossart
fixup! ASoC: soc-pcm: dpcm: fix playback/capture checks
26f1fa8 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
bardliao pushed a commit to bardliao/linux that referenced this issue May 29, 2020
@plbossart @bardliao
ASoC: soc-pcm: dpcm: fix playback/capture checks
c95e2de 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
bardliao pushed a commit to bardliao/linux that referenced this issue May 29, 2020
@plbossart @bardliao
ASoC: soc-pcm: dpcm: fix playback/capture checks
aac031a 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
bardliao pushed a commit that referenced this issue Jun 1, 2020
@plbossart @bardliao
ASoC: soc-pcm: dpcm: fix playback/capture checks
3c52044 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
bardliao pushed a commit that referenced this issue Jun 1, 2020
@plbossart @bardliao
ASoC: soc-pcm: dpcm: fix playback/capture checks
0a38eb8 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
plbossart added a commit to plbossart/sound that referenced this issue Jun 2, 2020
@plbossart
fixup! ASoC: soc-pcm: dpcm: fix playback/capture checks
d8e7324 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart added a commit that referenced this issue Jun 4, 2020
@plbossart
fixup! ASoC: soc-pcm: dpcm: fix playback/capture checks
f5f29fd 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
ranj063 pushed a commit that referenced this issue Jun 8, 2020
@plbossart @ranj063
ASoC: soc-pcm: dpcm: fix playback/capture checks
9d69ed3 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063 pushed a commit that referenced this issue Jun 8, 2020
@plbossart @ranj063
fixup! ASoC: soc-pcm: dpcm: fix playback/capture checks
2ddcdf5 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
plbossart added a commit that referenced this issue Jun 8, 2020
@plbossart
ASoC: soc-pcm: dpcm: fix playback/capture checks
c8915cc 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: #2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Jun 8, 2020
@plbossart @intel-lab-lkp
ASoC: soc-pcm: dpcm: fix playback/capture checks
0726f89 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

BugLink: thesofproject#2031
Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
ruscur pushed a commit to ruscur/linux that referenced this issue Jun 10, 2020
@plbossart @broonie
ASoC: soc-pcm: dpcm: fix playback/capture checks
b73287f 
Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
BugLink: thesofproject#2031
Link: https://lore.kernel.org/r/20200608194415.4663-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
MilhouseVH pushed a commit to MilhouseVH/linux that referenced this issue Jun 24, 2020
@plbossart @gregkh
ASoC: soc-pcm: dpcm: fix playback/capture checks
1bb707f 
[ Upstream commit b73287f ]

Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
BugLink: thesofproject/linux#2031
Link: https://lore.kernel.org/r/20200608194415.4663-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
PlaidCat added a commit to ctrliq/kernel-src-tree that referenced this issue Sep 12, 2024
@PlaidCat
ASoC: soc-pcm: dpcm: fix playback/capture checks
3f55d20 
jira LE-1907
Rebuild_History Non-Buildable kernel-4.18.0-294.el8
Rebuild_CHGLOG: - [sound] ALSA: ASoC: soc-pcm: dpcm: fix playback/capture checks (Jaroslav Kysela) [1869536]
Rebuild_FUZZ: 94.12%
commit-author Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
commit b73287f

Recent changes in the ASoC core prevent multi-cpu BE dailinks from
being used. DPCM does support multi-cpu DAIs for BE Dailinks, but not
for FE.

Handle the FE checks first, and make sure all DAIs support the same
capabilities within the same dailink.

Fixes: 9b5db05 ("ASoC: soc-pcm: dpcm: Only allow playback/capture if supported")
	Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
	Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
	Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
	Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
	Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
BugLink: thesofproject/linux#2031
Link: https://lore.kernel.org/r/20200608194415.4663-2-pierre-louis.bossart@linux.intel.com
	Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit b73287f)
	Signed-off-by: Jonathan Maple <jmaple@ciq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CML Applies to Comet Lake platform P1 Blocker bugs or important features SDW Applies to SoundWire bus for codec connection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@plbossart @bardliao @ClarexZhou @sinahuang