[DNM] ASoC: SOF: ipc4: stop host DMA for chain DMA pause #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike normal pipelines, chain-dma PCM DMA is stopped when PCM is put on pause. If host doesn't stop the DMA, this will trigger errors on FW. WIP implementation, this is a crude way to pass the chain-dma usage flag from IPC4 specific code, via generic PCM code to HDA host DMA handling. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202401-fix-chaindma-pause
branch
from
64e8ba3
to
e7b2ef7
Compare
|
This does seem to fix thesofproject/sof#8792 . Either we need to change the FW implementation, or a lot of clean up and merge this in kernel driver. |
|
Closing. This fixes the issue, but current understanding is that the fix should be on FW side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike normal pipelines, chain-dma PCM DMA is stopped when PCM is put on pause. If host doesn't stop the DMA, this will trigger errors on FW.
WIP implementation, this is a crude way to pass the chain-dma usage flag from IPC4 specific code, via generic PCM code to HDA host DMA handling.