xtos: perf_cnt: use correct timing_counter_get() #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
|
@tobonex btw, here's a portable way to get ccount (timing_counter_get() of zephyr/timing/timing.h) |
kv2019i
requested review from
abonislawski,
serhiy-katsyuba-intel and
marcinszkudlinski
serhiy-katsyuba-intel
approved these changes
Apr 10, 2024
lyakh
reviewed
Apr 12, 2024
xtos/include/sof/lib/perf_cnt.h
Outdated
|
|
||
| #include <zephyr/timing/timing.h> | ||
|
|
||
| #ifdef CONFIG_TIMING_FUNCTIONS |
There was a problem hiding this comment.
indentation... would be better to either leave as is or fix consistently
There was a problem hiding this comment.
ack, @lyakh can you recheck?
kv2019i
force-pushed
the
202404-timing-get-change
branch
from
4f0ea4a
to
7c55027
Compare
lgirdwood
approved these changes
Apr 12, 2024
Do not use arch_timing_counter() directly, but instead use the public timing_counter_get(). Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202404-timing-get-change
branch
from
7c55027
to
746641c
Compare
|
@wszypelt Hmm, I wonder what's going on with this. One TGL fail in quickbuild but the log shows "System.BadImageFormatException: Field token out of range". The captured file seems fine, so not sure what is happening. |
lgirdwood
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use arch_timing_counter() directly, but instead use the public timing_counter_get().