-
-
Notifications
You must be signed in to change notification settings - Fork 240
Use recursive subpattern to match balanced parentheses. #596
Conversation
This skips the trailing ) in [](http://example) while matches https://en.wikipedia.org/wiki/Haskell_(programming_language)
This doesn't look what I've requested in the past. I think it makes sense to ignore the trailing URL in the following case, bu treating it as part of a wrapper around the URL: However, I don't want it to be ignored in the following In a case like this, I don't want to make an attempt to treat the trailing parentheses as not part of the URL:
This regular expression also needs to be treated as somewhat performance sensitive. |
I'd also be fine with approaching cases like a URL wrapped in single quotes in the same way. |
the argument here is that unbalanced right parentheses are unlikely to be
part of the URL. We are using heuristics anyway as proper URL detection is
extremely hard and we have to consider the context. Your second case is
indeed rejected but I think this is what ppl usually want (foo
http://example.com/bar)
…On Wed, May 9, 2018, 02:41 Daniel Micay ***@***.***> wrote:
I'd also be fine with approaching cases like a URL wrapped in single
quotes in the same way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#596 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZaQvMYoS2fE-bO50kGsYYg4qet8_c3ks5twrmxgaJpZM4T2Abr>
.
|
atomic subgroup ?> is used for performance |
Has this PR been rejected? If so I can close it and use my local patch. |
Are the cases brought up by @thestinger resolved in the pull request? |
I don't understand the rationale of the cases brought up. With the PR,
(a statement in parentheses with a URL is not something I want to try to handle: https://foobar.com/baz) This is IMHO more intuitive and better than his proposed (
unmatched |
It's valid to have I'll wait for someone to submit a pull request implementing ignoring |
It wasn't the approach that I wanted and there isn't currently a maintainer/developer for the project. |
This skips the trailing ) in
[](http://example)
while matcheshttps://en.wikipedia.org/wiki/Haskell_(programming_language)
Fix #594