RtAudio: fix globally visible VERSION constant

[tmatth]

Calling it VERSION clashes with the VERSION macro of any autotools based project.

See https://gist.github.com/tmatth/e968b9e27e8cc806daba for a more complete explanation/example.

[radarsat1]

Hm, didn't realize the version is hardcoded in there.

[tmatth]

Hardcoding it is not so bad, it should just be called something else.

[garyscavone]

I already changed it in a prerelease version I am putting together. I changed it to use

#define RTAUDIO_VERSION “4.1.0pre”

in RtAudio.h and then the function:

std::string RtAudio :: getVersion( void ) throw()
{
return std::string( RTAUDIO_VERSION );
}

defined in RtAudio.cpp. Another user wrote to mention the compile problem and also point out that there could be problems with reporting the correct version when using a library.

I wish I had time to wrap up the new release but I’m currently swamped with higher priorities.

—gary

On Feb 6, 2014, at 10:24 AM, tmatth notifications@github.com wrote:

Hardcoding it is not so bad, it should just be called something else.

—
Reply to this email directly or view it on GitHub.

[tmatth]

OK, since it's not depending on your build system, I would write:
static const char * RTAUDIO_VERSION = "4.1.0pre";

Also note that in any case, you don't need the std::string( ) constructor in the getVersion() method.