Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the input of system-exclusive messages on ALSA #180

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

jpcima
Copy link
Contributor

@jpcima jpcima commented Oct 21, 2018

This repairs a problem introduced by commit 3155671
"alsa: fix a switch fallthrough warning", which makes it impossible to
receive any system-exclusive message.

This repairs a problem introduced by commit 3155671
"alsa: fix a switch fallthrough warning", which makes it impossible to
receive any system-exclusive message.
@SpotlightKid
Copy link
Contributor

Maybe it would be a good idea to fix the wrong indentation of the case statement above as well, which maybe contributed to this error.

@jpcima
Copy link
Contributor Author

jpcima commented Oct 21, 2018

Yes I think, so I've added this change too.

@jpcima
Copy link
Contributor Author

jpcima commented Mar 12, 2019

Ping. Can I do something in order to help include this fix?
The software FreeMajor has dysfunctional ALSA input on vanilla RtMidi.

@garyscavone garyscavone merged commit a14e6a5 into thestk:master Apr 12, 2019
keinstein pushed a commit to keinstein/rtmidi that referenced this pull request Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants