Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API names #82

Merged
merged 3 commits into from
Aug 27, 2018
Merged

Fix API names #82

merged 3 commits into from
Aug 27, 2018

Conversation

ryandesign
Copy link
Contributor

This PR corrects how a few of the API names are written:

  • "Core Midi" is changed to "CoreMIDI"
  • "Core Audio" is changed to "CoreAudio"
  • "Direct Sound" is changed to "DirectSound"

@ryandesign
Copy link
Contributor Author

Oops, I didn't realize rtaudio and rtmidi were separate projects. I've submitted PRs for the parts of these changes that belong in those projects here: thestk/rtmidi#172, thestk/rtaudio#155.

Should I remove the changes for those files from this PR?

@garyscavone
Copy link
Contributor

The changes to RtMidi and RtAudio will be "overwritten" during the next release, at which point the latest versions of RtMidi and RtAudio from their respective git repos will be copied over.

@garyscavone garyscavone merged commit 7fe70c4 into thestk:master Aug 27, 2018
@ryandesign ryandesign deleted the API-name-typos branch August 28, 2018 00:54
@ryandesign
Copy link
Contributor Author

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants