feat: Implement TAP-12 support #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quick comment: could you remove the contributing.md commit? |
D'oh, thought I rebased. Thanks, done! |
asraa
reviewed
Jun 9, 2022
1 task
asraa
previously approved these changes
Jun 10, 2022
Signed-off-by: Zachary Newman <z@znewman.net>
|
@mnm678 ping |
mnm678
previously approved these changes
Jun 13, 2022
Main changes: - allow IDs that aren't the SHA2 of the public key - but disallow multiple distinct keys with the same ID - test for TAP-12 compliance - Adding keys should disallow different keys with the same ID, but allow everything else - Verification should ensure that we have unique keys for each signature Fixes theupdateframework#232. Signed-off-by: Zachary Newman <z@znewman.net>
Signed-off-by: Zachary Newman <z@znewman.net>
Signed-off-by: Zachary Newman <z@znewman.net>
Signed-off-by: Zachary Newman <z@znewman.net>
|
Hoist by my own petard (#308)! No changes other than DCO and rebasing, but I need fresh approvals. |
asraa
approved these changes
Jun 13, 2022
mnm678
approved these changes
Jun 13, 2022
|
@znewman01 @rdimitrov I'm having trouble updating go-tuf in my library, because of a transitive dependency from rekor to v0.3.0 here. This removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #232
Release Notes: Add support for repositories that implement TAP-12 (allowing arbitrary key IDs). go-tuf itself will continue to emit pre-TAP-12-compliant key IDs.
Types of changes:
Description of the changes being introduced by the pull request:
Allows arbitrary key IDs in repos that we read, per TAP-12. (We will still only produce key IDs that are the SHA2 of the public key.)
Please verify and check that the pull request fulfills the following requirements: