Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verify): backport "Fix a vulnerability in the verification of threshold si… #375

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

znewman01
Copy link
Contributor

…gnatures (due to handling of keys with multiple IDs) (#369)" to v0.3.x release branch

  • add test for several signatures same key diff ID

  • fix verifying threshold signatures

  • add some comments

  • rename variables and add comments

Co-authored-by: Trishank Karthik Kuppusamy trishank.kuppusamy@datadoghq.com

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #
Release Notes:

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

…natures (due to handling of keys with multiple IDs) (theupdateframework#369)

* add test for several signatures same key diff ID

* fix verifying threshold signatures

* add some comments

* rename variables and add comments

Co-authored-by: Trishank Karthik Kuppusamy <trishank.kuppusamy@datadoghq.com>
Signed-off-by: Zachary Newman <z@znewman.net>
@znewman01 znewman01 merged commit b6695e4 into theupdateframework:v0.3.x Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants