fix: fail to load deprecated ecdsa verifier #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
rdimitrov
requested review from
znewman01,
kommendorkapten,
mnm678 and
trishankatdatadog
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
|
I wonder if we should disable govulncheck for the time being. It's nice, but it cannot be configured to silence vulnerabilities. In this case, it's referring to getting the fix from an unstable version which is not ideal. Update: I've decided to add a -json flag so it still runs but it doesn't fail the CI. |
Signed-off-by: Radoslav Dimitrov <dimitrovr@vmware.com>
znewman01
approved these changes
Aug 8, 2023
|
Can we get this merged and a new release cut? |
Yes, unfortunately, I cannot merge it unless there're 2 maintainer approvals :/ |
joshuagl
reviewed
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
The following PR updates the
set_ecdsapackage to use the correct verifier for the deprecated ECDSA key type - deprecated is hex encoded, and the compliant one is PEM-formatted.The deprecated verifier is added for both key type formats - "ecdsa" and "ecdsa-sha2-nistp256".
Once this is merged, there will be a patch release of v0.6.1 which should include it.
Fixes #527
Release Notes:
Types of changes:
!, as infeat!: change foo).Please verify and check that the pull request fulfills the following requirements: