Don't reset custom metadata when not specified #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I do the following:
```
tuf add --custom '{"foo":"bar"}' foo.txt
tuf add bar.txt
tuf add
```
I expect foo.txt to keep the metadata I give it, but that doesn't
currently happen as `tuf add` will set metadata of all staged files to
nil.
I have updated the logic to maintain custom metadata if the user hasn't
specified any.
Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
LGTM. |
lmars
added a commit
that referenced
this pull request
Jul 26, 2015
Don't reset custom metadata when not specified
rdimitrov
added a commit
to rdimitrov/go-tuf
that referenced
this pull request
Jan 25, 2024
rdimitrov
added a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I do the following:
I expect foo.txt to keep the metadata I give it, but that doesn't currently happen as
tuf addwill set metadata of all staged files to nil.I have updated the logic to maintain custom metadata if the user hasn't specified any.