Use transactions for database dump restore #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are breaking due to a unrelated code. The change to fix these tests were introduced in #113 |
…0/statistics into feature/db-transaction
|
This code also includes #113. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix an issue we are having. The database dump update is stuck, even considering that the process is still running.
I think I did not know about transactions when I coded the scripts part. This project was using the strange approach of creating a temp database, performing restoring the dump on it, then rename columns from the temp database to the wca_development one. The issue I was trying to solve when I coded this is the same that we solve when using transactions. So, we are removing the creative way of doing this and we are starting to use transactions.