Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method code too large exception #24

Closed
ZXTube opened this issue Aug 25, 2022 · 3 comments
Closed

Method code too large exception #24

ZXTube opened this issue Aug 25, 2022 · 3 comments

Comments

@ZXTube
Copy link

ZXTube commented Aug 25, 2022

Please fix the Method code too large exception.

In this Issue comment (Which is in the main dex2jar repository) the comment explained that this exception is not necessary at all and then explained how to edit the byte code so that this exception doesn't happen anymore.

Please make it so that this exception doesn't happen by default.

Thank you.

@ThexXTURBOXx
Copy link
Owner

I don't like fiddling around bytecode editing some jars we depend on since any version update will immediately break this.
However, maybe I am able to work around it differently by overwriting this function myself. I have not looked at the source code yet since I am very busy (and it is very late right now here).
But maybe I am able to play with this a bit in the next few days.
Also, another big problem I have with this approach: dex2jar also provides "recompiling" functionality and some users may complain afterwards anyway. But well... It's anyways better to support at least one-way conversion than no-way conversion :)

@ThexXTURBOXx
Copy link
Owner

I applied a similar workaround to the one in the linked comment in v53. Please see if it works for you, thanks!

@ZXTube
Copy link
Author

ZXTube commented Aug 26, 2022

Yes! Thank you it works now. Also thanks for answering quickly

@ZXTube ZXTube closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants