make final decision about arities of various protocol methods

[postspectacular]

Currently common protocol methods like translate, scale and the various basic vector math ops allow specifying coordinate args as vectors or individual coords, e.g.

(g/translate (a/aabb 1) (vec3 10 20 30))
(g/translate (a/aabb 1) [10 20 30])
(g/translate (a/aabb 1) 10 20 30)

About the last case:

Pros:

• in some cases avoids construction of temp vectors, though most internal usage doesn't make use of this arity option, since args are mostly vectors already

Cons:

• considerable additional effort required for maintaining 3-arities of each implementation
• currently missing implementations of this aritiy in various types
• extra argument type checking required for last case

Proposal:

• remove protocol 4-arg arity (w/ individual coords) from protocols and enforce usage of vector args

Thoughts?

[jackrusher]

I advocate simplicity/consistency/ease-of-maintenance over the slight potential performance increase gained by maintaining the extra arities.

[vl4dimir]

+1, what Jack said.

On Sunday, 10 April 2016, Jack Rusher notifications@github.com wrote:

I advocate simplicity/consistency/ease-of-maintenance over the slight
potential performance increase gained by maintaining the extra arities.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#38 (comment)

[postspectacular]

I love consensus! :) Will schedule this for week after next...

[postspectacular]

Okay guys, it's done:
a516bd5 + the 2 following commits to update tests/demos

will build another snapshot this week