Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @Security decorator using passport #63

Merged

Conversation

d0whc3r
Copy link
Contributor

@d0whc3r d0whc3r commented Oct 12, 2018

Examples and tests using passport-jwt

Examples and tests using passport-jwt
@d0whc3r d0whc3r mentioned this pull request Oct 12, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 83.333% when pulling f22dd86 on d0whc3r:feature/security_passport into edbdd25 on thiagobustamante:master.

@nkimaina
Copy link

Is this being merged?

@thiagobustamante thiagobustamante merged commit dc18a7c into thiagobustamante:master Oct 26, 2018
@mautematico
Copy link

Also interested: is it being merged?

@d0whc3r
Copy link
Contributor Author

d0whc3r commented Nov 9, 2018

Also interested: is it being merged?

Yes it was merged. Documentation is in README
https://github.com/thiagobustamante/typescript-rest#security-decorator

You could check for tests for more detailed implementation.

I don't know if it is published to npm...

@d0whc3r
Copy link
Contributor Author

d0whc3r commented Nov 9, 2018

No it is not published to npm, you need to import source code from github if you want to use @Security decorator

@mautematico
Copy link

You're right, it was merged!

I'm going to use it :) Thank you @d0whc3r

@garyevari
Copy link

Anyone able to comment on when a new version might be published to include this change?

@garyevari
Copy link

@d0whc3r using this code, how would you go about setting session to false on each of the endpoints so that passport doesn't complain about being unable to serialize/deserialize the user?

@garyevari
Copy link

Figured it out - will make a PR to config that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants