Sec dep #5
Closed
Sec dep #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumn (apache#922) * KOGITO-6399: DMN Expression Editor - undo decision table annotation column * Test cover * Test cover * Fixing not related failing test * Test * Test
Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.2) --- updated-dependencies: - dependency-name: moment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.5. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… fixes (apache#950) * 0.18.1 CHANGELOG * Remove extensionDependencies from SWF VS Code extension Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
…che#915) * ArrowLeft and ArrowRight action WIP * Vertical arrow keys navigation and table head/body traversion WIP * horizontal arrow keys navigation WIP * Fixed pixel bumping during cell focus * Arrow keys data cells navigation * Add keyboard navigation integration testAdd keyboard navigation integration tests * WIP cell focus only * FIX: edit mode, rightclick -> the focus is lost * close the menu if user is moving * Replace HTMLTableCellElement with HTMLTableCellElement for deprecation * Moved keyboard navigation logic to tablebody to work with context tableMoved keyboard navigation logic to tablebody to work with context tables * Context type: navigate to last row * ContextTable: use correct rowindex for last row * Fixed wrong margin on focus of the last additive-cell * Improved integration keyboard navigation & various menus * Improved Decision Table Keyboard Navigation Tests * Set initial isContextMenuOpen * Moved isContextMenuOpen logic to PopoverMenu component * Updated branch from upstream branch and fixed tests build failure * FocusUtils: ArrowNavigation with nested tables * TableBody: open the context menu when press enter if is a context cel * Add keyboard navigation tests for relation_expression_spec * Fixed globalContext errors in unit tests * fixed build:prod linting warning * tasks organization * FIX: Online-Editors always saving * Task writing * use decision_table_expression.ts and rename it to decision_table_expression_spec.ts * FIX: My understanding is, to test nested relation, the focused cell should be one of "nested 1", "nested 2" or "nested 3", like attached. Created manually, not as result of your tests. * FIX selectors introduced in cypress tests are heavily index based * FocusUtils unit tests WIP * Add FocusUtils unit tests * make it consistent with the currentEl. Use currentCell and currentBody * No need to call useContext since we are already calling a function that returns it: useBoxedExpression() * No need to call useContext since we are already calling a function that returns it: useBoxedExpression() * Unused constant. * Probably we don't need to set a callback for useEffect (which requires a re-render), and maybe you can change setIsContextMenuOpen inside the custom hook useContextMenuHandler * We should keep the contexts independent. This context is already available by using the usingTestingBoxedExpressionProviderContext or wrapComponentInContext methods, no need to pass it here. * Removed some console.log * View mode: Starting typing should automatically force the cell into edit mode. When the cell enters edit mode this way, it really means "replace" and it should assume the text is being replaced, not appended to. * Tab navigation WIP * FIX: View mode: Tab/shift+tab should move focus one cell to the right/left. At the last cell on a line tab should advance to the first row on the next line. FIX: Edit mode: Tab/shift+tab should end editing and advance the focus to the next cell to the right. Currently it ends editing but you lose the focus rectangle and have to hit tab again to get it back. You can’t type “AA” tab “BB” to put AA in cell 1 and BB in cell 2, especially if there is already text in the cells. * FIX When edit the last cell of a row, press tab -> focus is lost * add todo * FIX: select a td, then press shift -> focus is lost * Removed comment and todo: it's better not to manage the click event only in the TableBody also for EditableCell * Removed unused imports * Reverted changes to be used in a different PR * Open PMMLLiteralExpression on enter press * PMMLLiteralExpression: close on esc from table * Block navigation on PMMLLiteralExpression menu open * retrigger checks * Changed angle brackets casting * Fix: users need to press tab multiple times to edit cell in the DMNRunner table * Use DOM events instead of React events * Fixed typeTab cypress command according to the current event listening * Changed function defs to es6 * Unit tests WIP * Add option to disable keyboard navigation on the DMNRunner * Merge WIP * Merge WIP, Resolved TableBody.tsx conflicts * Removed typeTab() Cypress command in favor of the realPress() plugin * Fixed keyboard navigation from the last row in Context expression on the online-editor. Done creating TdAdditiveCell component like TdCell. * Tests WIP * TableHeader tabIndex implementation * write test colspan header cells * WIP * Implementation WIP * WIP * Rewriting tests for better debug infos WIP * Remove FocusUtils.test.tsx * focusNextDataCell WIP * TableUtils: getCellByIndex() * FocusUtils: focusUpperCell() * TableUtils: hasCellTabindex() * TableUtils: getCellCoordinates(): add colspan cells support * FocusUtils: focusNextDataCell() WIP * FocusUtils: focusNextCell(), focusLowerCell(), focusUpperCell() implementation * focusTextArea tests * Re enabled tests: focusTextArea and focusInsideCell * Removed old FocusUtils test file * moved onKeyDown logic to Table component * add Rowspan calculation and fixed context menu * decision_table_expression_spec: fixed and re-enabled "Go against edges" * decision_table_expression_spec: fixed and reenabled tests * focusTextArea -> focusTextInput with support for input text * TableUtils: getCellByCoordinates(): accept negative coordinates * FocusUtils: focusPrevCell() implementation * FIX: TableHeader warning: Each child in a list should have a unique "key" prop. * Use of focusPrevCell where focusPrevDataCell was used * Rewrite conditions * Add buggy test * FocusUtils: focusPrevCell: pass all tests * FocusUtils: focusPrevCell: refactor code * WIP * Table: keyboard editing for theader WIP * Table: keyboard editing for theader * Fixed failing cypress tests only in headless mode * Header cells border WIP * better border for thead cells * Show annotations border during cell editing * esc key doesn't cancel editing of annotations cell * Check annotation value in integration tests * FIX: remove cell focus on blur event * Reenable tests and fixed onblur test * Code review * Todo writing * context and relation doesn't have blue border for header cell * Improved css and and fixed focus for all tables * Removed already fixed bugs * FIX: special keys like F5 shouldn't opens popover * Annotations in online editor: fix keyDown and focus interaction * focusInsideCell doesn't work with functionDefinition header cell of invocation express * FIX:focusInsideCell: should not be executed for disabled ddl in PMML functions * focusInsideCell: doesn't' open menu for the first th of a function expression * FIX: the PMMLLiteralExpression select is blocking navigation when press enten key. Reason: when no option is available it was changing the setIsContextMenuOpen to true * Attributes a default value if width is undefined * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r836899864 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r837076840 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r837082164 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r836867368 * Empty commit * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r837257972 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838255345 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838180051 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838182052 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838184979 * Fix: CapsLock calls focusInsideCell * Adding position attributes to all cells * WIP * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838254424 * Empty commit * installed and configured cypress-image-snapshot * Created regression tests. * Configured snapshots path * Add cypress snapshots * Incremented regression tests threshold * Changed snapshots names * Add no_focus snapshots regression test for literal_expression_spec * Configured the threshold for the entire image * Add instructions to regenerate cypress snapshots Co-authored-by: Fabrizio Antonangeli <fantonan@fantonan.remote.csb> Co-authored-by: Luiz Motta <luizjoaomotta@gmail.com>
…itors/errai-bom (apache#932) * Bump jackson-databind in /packages/stunner-editors/errai-bom Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.1 to 2.12.6.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update `com.fasterxml.jackson` version to 2.12.6 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yeser Amer <yamer@redhat.com>
…-workflow-diagram-editor/errai-bom (apache#933) * Bump jackson-databind Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.1 to 2.12.6.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update `com.fasterxml.jackson` version to 2.12.6 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yeser Amer <yamer@redhat.com>
…e#914) * KOGITO-6859: Restoring Import Java Classes component * KOGITO-6859: Removing CompletableFuture + code smells * KOGITO-6859: Integrating getClasses * KOGITO-6859: Integrating getAccessors * KOGITO-6859: Integrating getAccessors * KOGITO-6859: Fixing searchbox focus * KOGITO-6859: Improving Classes management * KOGITO-6859: Fixing useCallback deps and message * KOGITO-6859: Fixing tests * KOGITO-6859: Revert previous change * KOGITO-6859: Fixing tests * KOGITO-6859: Fixing tests * KOGITO-6859: Fixing tests * KOGITO-6859: Integration with getAccessors * KOGITO-6859: Integration with getAccessors (Fields with FQCN) * KOGITO-6859: Integration with getAccessors (Fields with FQCN) * KOGITO-6292: Introducing DenyList to filter out Java Fields / Method * KOGITO-6841: Removing log * KOGITO-6859: Added getters with `is` prefix. * KOGITO-6859: Added requested comments * KOGITO-6859: Updated JDT.LS version
* bump-to-kie-8.20.Beta * Update pom for SWF branch too. * Removing kie versions from SWF diagram editor: not used
…pache#938) * KOGITO-6972: Add zoom control buttons to the mermaid generated SVG * KOGITO-6972: Add zoom control buttons to the mermaid generated SVG
* Upgrade plist * Update ch.qos.logback * KOGITO-6973: Fix gitignore for new serverless-workflow-diagram-editor streamline * Upgrade ch.qos-logback to 1.2.11 on stunner-editors * Upgrade ch.qos.logback to 1.2.11 on dashbuilder/appformer * Bump moment from 2.29.1 to 2.29.2 Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.2) --- updated-dependencies: - dependency-name: moment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Upgrade jboss.remoting.version to 5.0.20.Final in serverless-workflow-diagram-editor * Upgrade jsoup to 1.14.2 in serverless-workflow-diagram-editor * Upgrade node-forge to 1.3.0 * Upgrade simple-get * Upgrade trim-newlines * Upgrade ansi-regex * Upgrade mermaid * Fix yarn.lock * Update jsoup for stunner-editors and remove old comments Co-authored-by: Handrey Cunha <handrey.cunha@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… with keyboard (apache#929) * ArrowLeft and ArrowRight action WIP * Vertical arrow keys navigation and table head/body traversion WIP * horizontal arrow keys navigation WIP * Fixed pixel bumping during cell focus * Arrow keys data cells navigation * Add keyboard navigation integration testAdd keyboard navigation integration tests * WIP cell focus only * FIX: edit mode, rightclick -> the focus is lost * close the menu if user is moving * Replace HTMLTableCellElement with HTMLTableCellElement for deprecation * Moved keyboard navigation logic to tablebody to work with context tableMoved keyboard navigation logic to tablebody to work with context tables * Context type: navigate to last row * ContextTable: use correct rowindex for last row * Fixed wrong margin on focus of the last additive-cell * Improved integration keyboard navigation & various menus * Improved Decision Table Keyboard Navigation Tests * Set initial isContextMenuOpen * Moved isContextMenuOpen logic to PopoverMenu component * Updated branch from upstream branch and fixed tests build failure * FocusUtils: ArrowNavigation with nested tables * TableBody: open the context menu when press enter if is a context cel * Add keyboard navigation tests for relation_expression_spec * Fixed globalContext errors in unit tests * fixed build:prod linting warning * tasks organization * FIX: Online-Editors always saving * Task writing * use decision_table_expression.ts and rename it to decision_table_expression_spec.ts * FIX: My understanding is, to test nested relation, the focused cell should be one of "nested 1", "nested 2" or "nested 3", like attached. Created manually, not as result of your tests. * FIX selectors introduced in cypress tests are heavily index based * FocusUtils unit tests WIP * Add FocusUtils unit tests * make it consistent with the currentEl. Use currentCell and currentBody * No need to call useContext since we are already calling a function that returns it: useBoxedExpression() * No need to call useContext since we are already calling a function that returns it: useBoxedExpression() * Unused constant. * Probably we don't need to set a callback for useEffect (which requires a re-render), and maybe you can change setIsContextMenuOpen inside the custom hook useContextMenuHandler * We should keep the contexts independent. This context is already available by using the usingTestingBoxedExpressionProviderContext or wrapComponentInContext methods, no need to pass it here. * Removed some console.log * View mode: Starting typing should automatically force the cell into edit mode. When the cell enters edit mode this way, it really means "replace" and it should assume the text is being replaced, not appended to. * Tab navigation WIP * FIX: View mode: Tab/shift+tab should move focus one cell to the right/left. At the last cell on a line tab should advance to the first row on the next line. FIX: Edit mode: Tab/shift+tab should end editing and advance the focus to the next cell to the right. Currently it ends editing but you lose the focus rectangle and have to hit tab again to get it back. You can’t type “AA” tab “BB” to put AA in cell 1 and BB in cell 2, especially if there is already text in the cells. * FIX When edit the last cell of a row, press tab -> focus is lost * add todo * FIX: select a td, then press shift -> focus is lost * Removed comment and todo: it's better not to manage the click event only in the TableBody also for EditableCell * Removed unused imports * Reverted changes to be used in a different PR * Open PMMLLiteralExpression on enter press * PMMLLiteralExpression: close on esc from table * Block navigation on PMMLLiteralExpression menu open * retrigger checks * Changed angle brackets casting * Fix: users need to press tab multiple times to edit cell in the DMNRunner table * Use DOM events instead of React events * Fixed typeTab cypress command according to the current event listening * Changed function defs to es6 * Unit tests WIP * Add option to disable keyboard navigation on the DMNRunner * Merge WIP * Merge WIP, Resolved TableBody.tsx conflicts * Removed typeTab() Cypress command in favor of the realPress() plugin * Fixed keyboard navigation from the last row in Context expression on the online-editor. Done creating TdAdditiveCell component like TdCell. * Tests WIP * TableHeader tabIndex implementation * write test colspan header cells * WIP * Implementation WIP * WIP * Rewriting tests for better debug infos WIP * Remove FocusUtils.test.tsx * focusNextDataCell WIP * TableUtils: getCellByIndex() * FocusUtils: focusUpperCell() * TableUtils: hasCellTabindex() * TableUtils: getCellCoordinates(): add colspan cells support * FocusUtils: focusNextDataCell() WIP * FocusUtils: focusNextCell(), focusLowerCell(), focusUpperCell() implementation * focusTextArea tests * Re enabled tests: focusTextArea and focusInsideCell * Removed old FocusUtils test file * moved onKeyDown logic to Table component * add Rowspan calculation and fixed context menu * decision_table_expression_spec: fixed and re-enabled "Go against edges" * decision_table_expression_spec: fixed and reenabled tests * focusTextArea -> focusTextInput with support for input text * TableUtils: getCellByCoordinates(): accept negative coordinates * FocusUtils: focusPrevCell() implementation * FIX: TableHeader warning: Each child in a list should have a unique "key" prop. * Use of focusPrevCell where focusPrevDataCell was used * Rewrite conditions * Add buggy test * FocusUtils: focusPrevCell: pass all tests * FocusUtils: focusPrevCell: refactor code * WIP * Table: keyboard editing for theader WIP * Table: keyboard editing for theader * Fixed failing cypress tests only in headless mode * Header cells border WIP * better border for thead cells * Show annotations border during cell editing * esc key doesn't cancel editing of annotations cell * Check annotation value in integration tests * FIX: remove cell focus on blur event * Reenable tests and fixed onblur test * Code review * Todo writing * context and relation doesn't have blue border for header cell * Improved css and and fixed focus for all tables * Removed already fixed bugs * FIX: special keys like F5 shouldn't opens popover * Annotations in online editor: fix keyDown and focus interaction * focusInsideCell doesn't work with functionDefinition header cell of invocation express * FIX:focusInsideCell: should not be executed for disabled ddl in PMML functions * focusInsideCell: doesn't' open menu for the first th of a function expression * FIX: the PMMLLiteralExpression select is blocking navigation when press enten key. Reason: when no option is available it was changing the setIsContextMenuOpen to true * Attributes a default value if width is undefined * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r836899864 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r837076840 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r837082164 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r836867368 * Empty commit * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r837257972 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838255345 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838180051 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838182052 * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838184979 * Fix: CapsLock calls focusInsideCell * Adding position attributes to all cells * WIP * Fixes comment: https://github.com/kiegroup/kie-tools/pull/903#discussion_r838254424 * Empty commit * EditExpressionMenu: focus input text on open * EditExpressionMenu: save expression name on enter press * move NavigationKeysUtils in a better place * DataTypeSelector: restore the focus after selection * EditExpressionMenu: save expression data type on enter press * EditExpressionMenu: (online editor only) cancel editing and close popover on esc key * DataTypeSelector: use "button" selector * Code review * Moved Keyboard interaction tests to popover.spec.ts * Fixed tests in Cypress UI open case * Use of NavigationKeysUtils in PopoverMenu component * Closes: https://github.com/kiegroup/kie-tools/pull/929#discussion_r847288803 Closes: https://github.com/kiegroup/kie-tools/pull/929#discussion_r847270932 Fixed DataTypeSelector esc key that closed both select input and popover * Code review Co-authored-by: Fabrizio Antonangeli <fantonan@fantonan.remote.csb> Co-authored-by: Luiz Motta <luizjoaomotta@gmail.com>
* Extract FormStatus components * Move tests folder * Extract logic to bridge * Extract commom logic to custom hook * Fix types, variable names and form behavior * Use custom field for context input * Move common code to FormHook * Fix default values and improve types * Create a new package form-dmn * Remove required property * Fix i18n * Extract bridge and i18n * Export constants * Create specific package for dmn unitables * Extract input generation to bridge * Refactor types and isolate inputs and outputs * Isolate inputs and outputs * Improve types * Create unitables component * Completely isolated dmn from unitables * Improve typing and names * Create unitables-dmn * Rollback changes on boxed-expression * Bump header year to 2022 * Fix dependencies * Fix tests * Fix dmn runner table resize * Enable chaining method * Fix types * Fix tests * Delete DmnForm file * Fix table and cell resize * Bump up uniforms-patternfly version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.