Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yesno command #124

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Yesno command #124

merged 4 commits into from
Oct 13, 2022

Conversation

KY-Y0
Copy link
Contributor

@KY-Y0 KY-Y0 commented Oct 13, 2022 •
edited by thieleju
Loading

Added new command /yesno

Issue: #118

  • Added command to README.md commands list
  • Code is tested before submitting
  • Code is formatted with prettier (npm run format)
  • Deleted all console.log() or console.error() statements
  • Correct error handling => No 'The application did not respond' errors

Details

thieleju
thieleju approved these changes Oct 13, 2022
View reviewed changes
Copy link
Owner

@thieleju thieleju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! @KY-Y0

@thieleju thieleju merged commit cb8533d into thieleju:main Oct 13, 2022
@thieleju thieleju mentioned this pull request Oct 13, 2022
Closed
1 task
@thieleju thieleju added the hacktoberfest-accepted Your contribution will count to Hacktoberfest 2022 label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thieleju thieleju thieleju approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Your contribution will count to Hacktoberfest 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KY-Y0 @thieleju