Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(test): Dialog component #270

Closed
wants to merge 6 commits into from
Closed

Conversation

rovn208
Copy link
Contributor

@rovn208 rovn208 commented Jul 27, 2021

CHANGES

  • Setup jest-dom
  • Using userEvent instead of fireEvent
  • Refactor some tests
  • Change to test with src files
  • Add tests for the Dialog component
  • Resolve Unit tests for Dialog #261

@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/makeinvietnam/moai-docs/G3mwTZPoqErFfWW8gkkXMntvZ671
✅ Preview: https://moai-docs-git-fork-ngocro208-test-dialog-makeinvietnam.vercel.app

Copy link
Owner

@thien-do thien-do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ngocro208 this is a great PR, but I think I can't merge this fully:

  • The setting up parts (jest-dom, user-event) are merged in your other PR
  • The dialog part, well, I know this is my suggestion, but after thinking carefully I think I will go with v2 and having the headless ui dialog as the base, so it's likely we don't need these tests any more

@thien-do thien-do closed this Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for Dialog
2 participants