Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bandwidth parameter #11

Closed
wants to merge 1 commit into from
Closed

Conversation

cvicente
Copy link

@cvicente cvicente commented Oct 3, 2016

No description provided.

@coveralls
Copy link

coveralls commented Oct 3, 2016

Coverage Status

Coverage decreased (-0.3%) to 98.479% when pulling 2d6b109 on cvicente:add_bw_par into da8f6a2 on thiezn:master.

@cvicente
Copy link
Author

cvicente commented Oct 6, 2016

I'm a bit confused by the coveralls failure. It points to this line:
https://coveralls.io/jobs/18807786/source_files/1591162918#L101
However I do have a test covering that condition.
Let me know if there's anything I can do to get this merged. Thanks.

@cvicente cvicente mentioned this pull request Oct 11, 2016
@twdkeule twdkeule mentioned this pull request Jan 24, 2017
@thiezn
Copy link
Owner

thiezn commented May 15, 2017

Hi @cvicente Thanks for your submission and your patience, it took me a long while to find time to work on the library again. I've implemented the bandwidth parameter in commit d5f5970

I did decide not to add the M/G prefixes as you initially worked on to keep the api simple and aligned with the official iperf3 library

@thiezn thiezn closed this May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants