add duotone style #250
Closed
add duotone style #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duotone |
|
it's related to font files in FontAwesome but it's okay |
chriszielinski
added a commit
to chriszielinski/FontAwesome.swift
that referenced
this pull request
Mar 29, 2020
|
This adds the capability to use a duotone font, but does nothing about actually implementing. If you were to actually put this in a label, image, or other FontAwesomeUIControl subclass, it wouldn't produce the desired result. More needs to be added to the actual UIControl subclasses |
|
I'm closing this without merging for now. I want to come back and review this issue later. This solution is incomplete, and I want to implement parts of it, just not now |
christophertrudel
pushed a commit
to christophertrudel/FontAwesome.swift
that referenced
this pull request
Mar 10, 2021
christophertrudel
pushed a commit
to christophertrudel/FontAwesome.swift
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add duotone style #223, #230 , all you need is just drag and drop font-awesome pro