Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix today() failing if start_date is None - fixes #119 #120

Closed
wants to merge 1 commit into from

Conversation

bkleinen
Copy link
Contributor

simply added an "or today" to prevent result.sort from failing.

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.32%. Comparing base (41f0112) to head (d48d7fe).
Report is 82 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #120      +/-   ##
===========================================
- Coverage   100.00%   99.32%   -0.68%     
===========================================
  Files            2        3       +1     
  Lines          363      444      +81     
===========================================
+ Hits           363      441      +78     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikez
Copy link
Contributor

mikez commented Apr 17, 2024

@bkleinen Thanks for the pull request.

Two notes:

  1. To reproduce in Things, how do I make a task in Today where task['start_date'] is None?
  2. In Python, you can do datetime.datetime.today().date().isoformat().

@mikez
Copy link
Contributor

mikez commented Jul 31, 2024

@bkleinen In case this got lost, I'd like to repeat the question from #119 and the comment above. If I don't hear back within a week, I'll close this.

@mikez
Copy link
Contributor

mikez commented Aug 17, 2024

@bkleinen Closing this due to no answers coming back. Happy to open again once you return. (/cc @AlexanderWillner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants