AbstractTitanTx null ambiguity cleanup #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Guava Optional for newNodes * Collection.get* == null has two possible meanings - the key doesn't exist or the key has a null value, use contains* instead * Also set a few fields to final and removed unneeded dereferencing on close - clear() is called on those collections anyway
|
I also cleaned up the mixed tab/space indentation and trailing whitespace, but in a separate commit so you don't have to navigate those changes to see the actual work I did. |
mbroecheler
added a commit
that referenced
this pull request
Aug 24, 2012
|
Merged the pull request manually. Accepted all changes but since I changed the VertexCache contract to not allow null vertices I left the getExistingVertex method to using node!=null for slightly better performance since this method can be called very frequently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into NPEs when I fixed a bug in this class due to some null ambiguity issues. This pull requests removes the use of null where it's not part of a contracted method return: