Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#234 HTML tweaks per thiago #238

Closed
wants to merge 6 commits into from
Closed

#234 HTML tweaks per thiago #238

wants to merge 6 commits into from

Conversation

labboy0276
Copy link
Contributor

I just submitted code and now I want to make sure it's ready for primetime!!!

In order to do that I need to first go through the below checklist entitled "For Me" because I respect my coworkers and want to get this PR into the best place possible before i ask for their time. When i am done i will then summon reviewers for feedback and comment. These reviewers will have about a week to complete their review.

If they do not review in the time alloted or have no change requests or blocking concerns the person who opened the pull request will apply the "Ready to merge" label which will ping the Keepers of Faith to press the merge button.

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated this repo's README if my code changes it
  • I've updated relevant documentation it my code changes it

Finally

  • I've requested a review with relevant people
  • I've moved this ticket into the "Ready for review" swimlane

@labboy0276 labboy0276 mentioned this pull request Oct 13, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants