Winston/add embedded wallet connector #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(wallets): update iframe initialization for thirdwebEmbeddedWalletSdk chore(wallets): add THIRDWEB_EWS_SDK_VERSION to turbo.json
chore(wallets): update wallets exported variables
build(ews): expose the right exports in thirdwebEmbeddedWallet
chore(wallets): remove dev logs
|
/release-pr |
|
/release-pr |
ElasticBottle
commented
Sep 9, 2023
…n/add-embedded-wallet-connector
|
/release-pr |
edwardysun
reviewed
Sep 14, 2023
| } | ||
|
|
||
| // update chain in wallet | ||
| await this.user?.wallet.setChain({ chain: "Ethereum" }); // just pass Ethereum no matter what chain we are going to connect |
There was a problem hiding this comment.
Does the chain in the underlying embedded wallet basically not matter anymore?
|
this looks awesome! would love to see this in action tomorrow in our 1:1 |
…n/add-embedded-wallet-connector
|
/release-pr |
…n/add-embedded-wallet-connector
chore: update pnpm-lock
…b.com/thirdweb-dev/js into winston/add-embedded-wallet-connector
Merged
jnsdls
pushed a commit
that referenced
this pull request
Jun 19, 2024
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.9 to 7.22.11. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.11/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
This exposes the
EmbeddedWalletSdkin a consumable fashion for the rest of the thirdweb SDK.Changes made
EmbeddedWalletConnectorandEmbeddedWalletclass to the@thirdweb-dev/walletspackageHow to test