Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: In-app wallets for react native v5 #3064

Merged
merged 11 commits into from
May 21, 2024
Merged

feat: In-app wallets for react native v5 #3064

merged 11 commits into from
May 21, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 17, 2024

PR-Codex overview

This PR introduces in-app wallet support for React Native, updates authentication modules, and refactors file paths.

Detailed summary

  • Added in-app wallet support for React Native
  • Updated authentication modules and interfaces
  • Refactored file paths for consistency

The following files were skipped due to too many changes: packages/thirdweb/src/extensions/erc721/write/sigMint.ts, packages/thirdweb/src/utils/jwt/encode-jwt.ts, packages/thirdweb/src/wallets/in-app/implementations/lib/auth/passkeys.ts, packages/thirdweb/src/extensions/erc20/write/sigMint.ts, packages/thirdweb/src/wallets/in-app/implementations/lib/auth/index.ts, packages/thirdweb/src/wallets/in-app/native/helpers/auth/cognitoAuth.ts, packages/thirdweb/src/extensions/airdrop/write/airdropERC20WithSignature.ts, packages/thirdweb/src/extensions/airdrop/write/airdropERC721WithSignature.ts, packages/thirdweb/src/extensions/airdrop/write/airdropERC1155WithSignature.ts, packages/thirdweb/src/wallets/in-app/core/lib/in-app-wallet-calls.ts, packages/react-native-adapter/package.json, packages/thirdweb/src/extensions/erc4337/account/common.ts, packages/thirdweb/src/wallets/in-app/web/types.ts, packages/thirdweb/src/wallets/in-app/native/helpers/wallet/recoveryCode.ts, packages/thirdweb/src/wallets/in-app/implementations/lib/core/in-app-wallet.ts, packages/thirdweb/src/wallets/in-app/native/helpers/constants.ts, packages/thirdweb/package.json, packages/thirdweb/src/wallets/in-app/native/helpers/auth/middleware.ts, packages/thirdweb/src/wallets/in-app/native/helpers/wallet/encryption.ts, packages/thirdweb/src/wallets/in-app/native/helpers/wallet/creation.ts, packages/thirdweb/src/wallets/in-app/core/authentication/type.ts, packages/thirdweb/src/wallets/in-app/native/helpers/storage/local.ts, packages/thirdweb/src/wallets/in-app/core/authentication/index.ts, packages/thirdweb/src/wallets/in-app/web/lib/web-connector.ts, packages/thirdweb/src/wallets/in-app/native/helpers/wallet/retrieval.ts, packages/thirdweb/src/wallets/in-app/native/native-connector.ts, packages/thirdweb/src/wallets/in-app/native/helpers/api/fetchers.ts, packages/thirdweb/src/wallets/in-app/native/auth.ts, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: d9faad2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/react-native-adapter Minor
thirdweb Minor
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label May 17, 2024
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review

packages/thirdweb/package.json Outdated Show resolved Hide resolved
packages/thirdweb/package.json Outdated Show resolved Hide resolved
packages/react-native-adapter/package.json Outdated Show resolved Hide resolved
packages/thirdweb/package.json Outdated Show resolved Hide resolved
packages/thirdweb/src/utils/random.ts Outdated Show resolved Hide resolved
packages/thirdweb/src/utils/random.ts Show resolved Hide resolved
packages/thirdweb/src/wallets/in-app/native/auth.ts Outdated Show resolved Hide resolved
packages/thirdweb/src/wallets/in-app/web/index.ts Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #3064 will not alter performance

Comparing joaquim/rn-iaw (d9faad2) with main (d95eb31)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

github-actions bot commented May 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.21 KB (-0.08% 🔽) 785 ms (-0.08% 🔽) 389 ms (+148.84% 🔺) 1.2 s
thirdweb (cjs) 88.59 KB (-0.08% 🔽) 1.8 s (-0.08% 🔽) 670 ms (+1.97% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 4.75 KB (-0.13% 🔽) 95 ms (-0.13% 🔽) 37 ms (+256.85% 🔺) 132 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 54 ms (+995.19% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 15.64 KB (-32.32% 🔽) 313 ms (-32.32% 🔽) 45 ms (+18.56% 🔺) 357 ms

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 84.97854% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 63.83%. Comparing base (b46173f) to head (d9faad2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
+ Coverage   63.64%   63.83%   +0.19%     
==========================================
  Files         781      783       +2     
  Lines       56062    56473     +411     
  Branches     3189     3199      +10     
==========================================
+ Hits        35678    36047     +369     
- Misses      19715    19757      +42     
  Partials      669      669              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from 1e4959e
packages 63.40% <84.97%> (+0.24%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...s/thirdweb/src/auth/core/generate-login-payload.ts 100.00% <100.00%> (ø)
...sions/airdrop/write/airdropERC1155WithSignature.ts 100.00% <100.00%> (ø)
...ensions/airdrop/write/airdropERC20WithSignature.ts 100.00% <100.00%> (ø)
...nsions/airdrop/write/airdropERC721WithSignature.ts 100.00% <100.00%> (ø)
...s/thirdweb/src/extensions/erc1155/write/sigMint.ts 97.60% <100.00%> (ø)
...ges/thirdweb/src/extensions/erc20/write/sigMint.ts 95.78% <100.00%> (ø)
.../thirdweb/src/extensions/erc4337/account/common.ts 95.12% <100.00%> (ø)
...es/thirdweb/src/extensions/erc721/write/sigMint.ts 96.42% <100.00%> (ø)
packages/thirdweb/src/utils/random.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/utils/uint8-array.ts 88.98% <100.00%> (ø)
... and 10 more

... and 6 files with indirect coverage changes

@joaquim-verges
Copy link
Member Author

/release-pr

@joaquim-verges joaquim-verges removed the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label May 20, 2024
@joaquim-verges joaquim-verges changed the title [WIP] In-app wallets for react native v5 feat: In-app wallets for react native v5 May 20, 2024
@joaquim-verges
Copy link
Member Author

/release-pr

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joaquim-verges joaquim-verges added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@joaquim-verges joaquim-verges merged commit f55fa4c into main May 21, 2024
15 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/rn-iaw branch May 21, 2024 00:04
@jnsdls jnsdls mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants