Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deep linking to wallet app when using Connect UI #3083

Merged
merged 13 commits into from
May 22, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented May 20, 2024

PR-Codex overview

This PR adds deep linking support for specific wallets, updates wallet information, and enhances wallet creation options.

Detailed summary

  • Added deep link support for specific wallets
  • Updated wallet information for various wallets
  • Enhanced wallet creation options with deep linking support

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/__generated__/wallet-infos.ts, packages/thirdweb/src/wallets/__generated__/wallet-ids.ts, packages/thirdweb/scripts/wallets/generate.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx, packages/thirdweb/src/wallets/__generated__/wallet/xyz.bonuz/image.ts, packages/thirdweb/package.json, packages/thirdweb/src/wallets/__generated__/wallet/com.neonwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/pub.dg/image.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx, packages/thirdweb/src/wallets/__generated__/wallet/com.icewal/image.ts, packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.shido/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.ozonewallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.myabcwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.foxwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/one.metapro.wallet/image.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: b4c1bee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
thirdweb Minor
@thirdweb-dev/sdk Patch
playground-web Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 20, 2024

CodSpeed Performance Report

Merging #3083 will not alter performance

Comparing cnct-1057 (b4c1bee) with main (c3b8cc7)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

github-actions bot commented May 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.21 KB (0%) 785 ms (0%) 2.8 s (+4.75% 🔺) 3.6 s
thirdweb (cjs) 88.59 KB (0%) 1.8 s (0%) 7.4 s (-12.25% 🔽) 9.2 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 248 ms (-61.52% 🔽) 343 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 50 ms (-1.57% 🔽) 60 ms
thirdweb/react (minimal + tree-shaking) 15.63 KB (0%) 313 ms (0%) 557 ms (+47.22% 🔺) 870 ms

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 30.35714% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 62.28%. Comparing base (c3b8cc7) to head (b4c1bee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3083      +/-   ##
==========================================
- Coverage   62.34%   62.28%   -0.06%     
==========================================
  Files         802      803       +1     
  Lines       59944    60056     +112     
  Branches     3220     3219       -1     
==========================================
+ Hits        37374    37408      +34     
- Misses      21901    21979      +78     
  Partials      669      669              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from 16afc8d
packages 61.54% <30.35%> (-0.08%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
.../web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx 18.91% <12.00%> (-1.09%) ⬇️
...t/web/ui/ConnectWallet/Modal/DeepLinkConnectUI.tsx 35.63% <35.63%> (ø)

@MananTank MananTank marked this pull request as draft May 20, 2024 18:54
@MananTank MananTank changed the title Add support for deep linking to MM mobile app when using Connect UI Add support for deep linking to wallet app when using Connect UI May 20, 2024
@MananTank MananTank marked this pull request as ready for review May 20, 2024 19:41
@MananTank MananTank requested a review from jnsdls as a code owner May 20, 2024 19:41
.changeset/large-parrots-suffer.md Outdated Show resolved Hide resolved
@MananTank MananTank marked this pull request as draft May 20, 2024 19:52
@MananTank MananTank marked this pull request as ready for review May 20, 2024 20:03
@MananTank MananTank marked this pull request as draft May 20, 2024 21:18
@MananTank
Copy link
Member Author

/release-pr

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 6:03am

@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

1 similar comment
@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

@MananTank
Copy link
Member Author

/release-pr

@MananTank MananTank marked this pull request as ready for review May 21, 2024 14:53
@MananTank MananTank marked this pull request as draft May 21, 2024 14:53
@MananTank
Copy link
Member Author

/release-pr

@MananTank MananTank marked this pull request as ready for review May 21, 2024 15:34
@MananTank MananTank added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@joaquim-verges joaquim-verges merged commit 5994685 into main May 22, 2024
16 of 17 checks passed
@joaquim-verges joaquim-verges deleted the cnct-1057 branch May 22, 2024 03:16
@jnsdls jnsdls mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants