Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Phone number login for react native #3110

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented May 22, 2024

PR-Codex overview

This PR focuses on adding phone number sign-in functionality for React Native using Amazon Cognito.

Detailed summary

  • Added phone number sign-in and sign-up functions in cognitoAuth.ts
  • Updated types for user details API
  • Modified package dependencies in package.json
  • Added sendVerificationSms function for phone verification

The following files were skipped due to too many changes: packages/react-native-adapter/README.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 1:49am

Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: d698343

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@thirdweb-dev/react-native-adapter Patch
thirdweb Patch
@thirdweb-dev/sdk Patch
playground-web Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 22, 2024

CodSpeed Performance Report

Merging #3110 will not alter performance

Comparing joaquim/in-app-phone (d698343) with main (e6fc042)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

github-actions bot commented May 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.21 KB (0%) 785 ms (0%) 432 ms (+5.11% 🔺) 1.3 s
thirdweb (cjs) 88.59 KB (0%) 1.8 s (0%) 1.2 s (+37.14% 🔺) 3 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 40 ms (-59.33% 🔽) 135 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 15 ms (+82.08% 🔺) 25 ms
thirdweb/react (minimal + tree-shaking) 15.63 KB (0%) 313 ms (0%) 201 ms (+36.24% 🔺) 513 ms

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.35%. Comparing base (c3b8cc7) to head (d698343).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3110   +/-   ##
=======================================
  Coverage   62.34%   62.35%           
=======================================
  Files         802      802           
  Lines       59944    59951    +7     
  Branches     3220     3220           
=======================================
+ Hits        37374    37381    +7     
  Misses      21901    21901           
  Partials      669      669           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from 0172cfc
packages 61.62% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...web/src/wallets/in-app/core/authentication/type.ts 100.00% <100.00%> (ø)

@joaquim-verges joaquim-verges merged commit 49aa6e4 into main May 22, 2024
17 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/in-app-phone branch May 22, 2024 01:52
@jnsdls jnsdls mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant