Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inApp native wallet creation #3345

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 17, 2024

PR-Codex overview

This PR focuses on fixing the creation of react native inAppWallet.

Detailed summary

  • Fixed creation of react native inAppWallet
  • Updated import statements in create-wallet.ts
  • Removed unnecessary comments and error throwing
  • Improved code readability and maintainability

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 4:04am

Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: c2de4e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Jun 17, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title feat: implement inApp wallet creation fix: inApp native wallet creation Jun 17, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review June 17, 2024 04:01
@joaquim-verges joaquim-verges merged commit 79e6a04 into main Jun 17, 2024
12 of 13 checks passed
@joaquim-verges joaquim-verges deleted the feat/in-app-wallet-integration branch June 17, 2024 04:02
Copy link

codspeed-hq bot commented Jun 17, 2024

CodSpeed Performance Report

Merging #3345 will create unknown performance changes

Comparing feat/in-app-wallet-integration (c2de4e1) with main (79e6a04)

Summary

🆕 9 new benchmarks

Benchmarks breakdown

Benchmark main feat/in-app-wallet-integration Change
🆕 encode tx (contract abi) N/A 406.2 µs N/A
🆕 encode tx (human readable) N/A 382.4 µs N/A
🆕 encode tx (json abi) N/A 191.9 µs N/A
🆕 encode tx (prepared method) N/A 338.8 µs N/A
🆕 keccakId N/A 1.3 ms N/A
🆕 units:toTokens(12345678901234567890n, 18) N/A 25.4 µs N/A
🆕 units:toTokens(40000000000000000000n, 18) N/A 184.3 µs N/A
🆕 units:toUnits("40", 18) N/A 33.7 µs N/A
🆕 units:toUnits("40.0", 18) N/A 37.4 µs N/A

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.59 KB (0%) 812 ms (0%) 1.9 s (-31.16% 🔽) 2.7 s
thirdweb (cjs) 90.32 KB (0%) 1.9 s (0%) 5.9 s (+9.62% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 150 ms (-21.69% 🔽) 245 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 113 ms (+174.9% 🔺) 123 ms
thirdweb/react (minimal + tree-shaking) 13.47 KB (0%) 270 ms (0%) 1.5 s (+440.09% 🔺) 1.7 s

@jnsdls jnsdls mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant