Add ERC721 extension: updateMetadata & updateBatchBaseURI #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kien-ngo
added
the
DO NOT MERGE
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a9ce10f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3347 will not alter performanceComparing Summary
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
==========================================
+ Coverage 62.82% 62.89% +0.07%
==========================================
Files 860 861 +1
Lines 63715 63838 +123
Branches 3449 3464 +15
==========================================
+ Hits 40026 40151 +125
+ Misses 23014 23010 -4
- Partials 675 677 +2
*This pull request uses carry forward flags. Click here to find out more.
|
packages/thirdweb/src/extensions/erc721/drops/write/updateMetadata.test.ts
Show resolved
Hide resolved
packages/thirdweb/src/extensions/erc721/drops/write/updateMetadata.ts
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/extensions/erc721/drops/write/updateMetadata.ts
Outdated
Show resolved
Hide resolved
kien-ngo
removed
the
DO NOT MERGE
jnsdls
reviewed
Jun 17, 2024
kien-ngo
changed the title
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR adds an ERC721 extension `updateMetadata` for updating NFT metadata in batches.
### Detailed summary
- Added `updateMetadata` function to update NFT metadata
- Implemented `getUpdateMetadataParams` to prepare transaction
- Added tests for `updateMetadata` function
- Introduced `freezeBatchBaseURI` function and related utilities
> The following files were skipped due to too many changes: `packages/thirdweb/src/extensions/erc721/__generated__/DropERC721/write/freezeBatchBaseURI.ts`, `packages/thirdweb/src/extensions/erc721/__generated__/DropERC721/write/setMaxTotalSupply.ts`, `packages/thirdweb/src/extensions/erc721/__generated__/DropERC721/write/updateBatchBaseURI.ts`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR adds an ERC721 extension
updateMetadatafor updating NFT metadata in a batch.Detailed summary
updateMetadatafunction to update NFT metadata in ERC721 extensiongetUpdateMetadataParamsfunction to prepare update metadata parametersupdateMetadatafunction with different scenariosFreezeBatchBaseURIParamsand related functions for freezing batch base URI