Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): add ecosystem and sponsored transaction pages for in-app wallet #4719

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to enhance the in-app wallet feature by adding expanded navigation links, ecosystem integration, and sponsored transaction previews.

Detailed summary

  • Added expanded navigation links in the in-app wallet section
  • Integrated ecosystem functionality for in-app wallet connections
  • Added a sponsored transaction preview component for in-app wallets

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 1:13am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 20, 2024 1:13am
thirdweb-www ⬜️ Skipped (Inspect) Sep 20, 2024 1:13am
wallet-ui ⬜️ Skipped (Inspect) Sep 20, 2024 1:13am

@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 20, 2024 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2024 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2024 00:29 Inactive
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: c67d8a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Sep 20, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title feat: add ecosystem and sponsored transaction pages for in-app wallet feat(playground): add ecosystem and sponsored transaction pages for in-app wallet Sep 20, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review September 20, 2024 00:29
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.62%. Comparing base (dab7b4e) to head (c67d8a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4719   +/-   ##
=======================================
  Coverage   50.62%   50.62%           
=======================================
  Files        1025     1025           
  Lines       54571    54571           
  Branches     3892     3892           
=======================================
  Hits        27626    27626           
  Misses      26312    26312           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from dab7b4e
packages 46.87% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 394 ms (+59.79% 🔺) 1.3 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 616 ms (+3.16% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 93 ms (+353.31% 🔺) 190 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 58 ms (+518.13% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 157 ms (+133.91% 🔺) 492 ms


export const metadata: Metadata = {
metadataBase,
title: "Sign In, Account Abstraction and SIWE Auth | thirdweb Connect",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is old copy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. let me change that

Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

…n-app wallet (#4719)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
The focus of this PR is to enhance the in-app wallet feature by adding expanded navigation links, ecosystem connection, and sponsored transaction previews.

### Detailed summary
- Added expanded navigation links in the in-app wallet section
- Implemented ecosystem connection functionality
- Included sponsored transaction previews for in-app wallets

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the feat_add_ecosystem_and_sponsored_transaction_pages_for_in-app_wallet branch from 913ca0a to c67d8a9 Compare September 20, 2024 01:10
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 20, 2024 01:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2024 01:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2024 01:10 Inactive
@graphite-app graphite-app bot merged commit c67d8a9 into main Sep 20, 2024
30 checks passed
@graphite-app graphite-app bot deleted the feat_add_ecosystem_and_sponsored_transaction_pages_for_in-app_wallet branch September 20, 2024 01:13
@vercel vercel bot temporarily deployed to Production – docs-v2 September 20, 2024 01:13 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 20, 2024 01:13 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www September 20, 2024 01:13 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants