Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): update ecosystem for prod #4731

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to update the ecosystem returned based on the environment in the getEcosystem function.

Detailed summary

  • Updated the ecosystem returned based on the environment in getEcosystem function.
  • Changed the URL check to .thirdweb-dev.com for dev ecosystem.
  • Updated the return values for dev and prod ecosystems.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 10:53pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 20, 2024 10:53pm
thirdweb-www ⬜️ Skipped (Inspect) Sep 20, 2024 10:53pm
wallet-ui ⬜️ Skipped (Inspect) Sep 20, 2024 10:53pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2024 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 20, 2024 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2024 22:51 Inactive
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: e478024

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Sep 20, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title feat: update ecosystem selection logic for in-app wallet feat(playground): update ecosystem for prod Sep 20, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review September 20, 2024 22:51
@joaquim-verges joaquim-verges merged commit f8e6998 into main Sep 20, 2024
26 of 27 checks passed
@joaquim-verges joaquim-verges deleted the feat_update_ecosystem_selection_logic_for_in-app_wallet branch September 20, 2024 22:52
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.61%. Comparing base (07d191b) to head (e478024).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4731   +/-   ##
=======================================
  Coverage   50.61%   50.61%           
=======================================
  Files        1024     1024           
  Lines       54578    54578           
  Branches     3888     3888           
=======================================
  Hits        27624    27624           
  Misses      26321    26321           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 07d191b
packages 46.86% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 1.5 s (+5.75% 🔺) 2.3 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 2.7 s (+9.37% 🔺) 4.7 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 155 ms (-4.66% 🔽) 252 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 58 ms (+114.24% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 368 ms (+95.1% 🔺) 702 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant