[SDK] Fix: ensure optional chains are passed to wc #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 842baa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
force-pushed
the
fix/wc-optional-chains
branch
from
d5325c3
to
032cbf4
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4838 +/- ##
==========================================
- Coverage 47.73% 47.70% -0.03%
==========================================
Files 1051 1052 +1
Lines 56707 56754 +47
Branches 3903 3904 +1
==========================================
+ Hits 27068 27075 +7
- Misses 28951 28991 +40
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Sep 28, 2024
jnsdls
approved these changes
Sep 28, 2024
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on enhancing the `wallet-connect` functionality by ensuring that optional chains are correctly handled in the wallet connection request process.
### Detailed summary
- Updated the destructuring of the return value from `getChainsToRequest` to include `requiredChain`.
- Changed how `optionalChains` and `chains` are assigned in `connectWC` and `initProvider` functions.
- Modified the return structure of `getChainsToRequest` to include `requiredChain` and `optionalChains`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
joaquim-verges
force-pushed
the
fix/wc-optional-chains
branch
from
032cbf4
to
842baa0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the handling of optional chains in the
wallet-connectfunctionality, ensuring that required and optional chains are correctly processed during wallet connection requests.Detailed summary
getChainsToRequestto returnrequiredChainandoptionalChainsinstead of justchainsToRequest.connectWCandinitProviderfunctions to userequiredChainfor thechainsparameter.optionalChainsare passed correctly in wallet connect requests.