[Unity] fix unity wallet connect #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88036fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 69.49% 69.49%
=======================================
Files 233 233
Lines 11213 11213
Branches 1381 1381
=======================================
Hits 7793 7793
Misses 2678 2678
Partials 742 742 ☔ View full report in Codecov by Sentry. |
iketw
reviewed
May 1, 2023
| case "walletConnect": | ||
| walletInstance = new WalletConnect({ | ||
| case "walletConnectV1": | ||
| walletInstance = new WalletConnectV1({ |
There was a problem hiding this comment.
The reason for this is to support the most popular wallets correct? This is not fixing any bugs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.