Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't translate button's string #38

Closed
wartinw opened this issue Jun 2, 2020 · 3 comments · Fixed by #39
Closed

Can't translate button's string #38

wartinw opened this issue Jun 2, 2020 · 3 comments · Fixed by #39
Labels
bug Something isn't working

Comments

@wartinw
Copy link
Contributor

wartinw commented Jun 2, 2020

in /niara/blob/master/modules/beesblogrecentposts/views/templates/hooks/home.tpl
Line 51 is:
<p><a class="btn btn-primary" href="{$post->link|escape:'htmlall':'UTF-8'}" title="{$post->title|escape:'htmlall':'UTF-8'}">Read More</a></p>

but should be:
<p><a class="btn btn-primary" href="{$post->link|escape:'htmlall':'UTF-8'}" title="{$post->title|escape:'htmlall':'UTF-8'}">{l s='Read More' mod='beesblogrecentposts'}</a></p>

In /niara/blob/master/modules/beesblogrelatedproducts/views/templates/hooks/product.tpl

Line 42 is:
<p><a class="btn btn-primary" href="{$post.link|escape:'htmlall':'UTF-8'}" title="{$post.title|escape:'htmlall':'UTF-8'}">Read More</a></p>

Should be:
<p><a class="btn btn-primary" href="{$post.link|escape:'htmlall':'UTF-8'}" title="{$post.title|escape:'htmlall':'UTF-8'}">{l s='Read More' mod='beesblogrelatedproducts'}</a></p>

Same in these files:
beesblogpopularposts/views/templates/hooks/home.tpl
beesblogpopularposts/views/templates/hooks/product.tpl
beesblogrecentposts/views/templates/hooks/product.tpl

@getdatakick getdatakick added the bug Something isn't working label Jun 3, 2020
@wartinw
Copy link
Contributor Author

wartinw commented Jun 3, 2020

Hi. I was trying to make a branch, fix the code and make a pull request. Could you give permission? Is it possible?
Thanks!

@getdatakick
Copy link
Contributor

You need to fork the repository first. Then commit and push your changes to your repository. After that, you can go to original/this repository and create pull request from your repo.

No permissions needed.

@wartinw
Copy link
Contributor Author

wartinw commented Jun 3, 2020

Thanks, I did it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants