Skip to content

Commit 9682008

Browse files
fix(image loader): clear src and srct on changes and pre load image
prevents rendered image being reused when inputs change
1 parent bc4bacf commit 9682008

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/app/image-loader/image-loader/image-loader.component.spec.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,4 +218,10 @@ describe('ImageLoaderComponent', () => {
218218
component.ngOnChanges();
219219
expect(spy).toHaveBeenCalled();
220220
});
221+
222+
it('should preload image on changes', () => {
223+
const spy = spyOn(component, 'preloadImage');
224+
component.ngOnChanges();
225+
expect(spy).toHaveBeenCalled();
226+
});
221227
});

src/app/image-loader/image-loader/image-loader.component.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,9 @@ export class ImageLoaderComponent implements OnInit, AfterViewInit, OnDestroy, O
340340
* @memberof ImageLoaderComponent
341341
*/
342342
public ngOnChanges(): void {
343+
this.src = '';
344+
this.srcset = '';
343345
this.setPlaceholder();
346+
this.preloadImage();
344347
}
345348
}

0 commit comments

Comments
 (0)