Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update gruntfile #36

Merged
merged 9 commits into from
Nov 12, 2015
Merged

Feature: Update gruntfile #36

merged 9 commits into from
Nov 12, 2015

Conversation

edoparearyee
Copy link
Collaborator

This PR includes the following updates the build process:

  • Disable qualified-headings options in lesslint task as bootstrap doesn't follow this rule.
  • Allow style tag in htmllint for use in modules prototype pages.
  • Split grunt watch tasks into smaller tasks so only the nessesary tasks are called when updating files.
  • Move .csslintrc and .htmllint files into project root like jshintrc so easier to find.
  • Lint html files in modules folder as well
  • Remove grunt serverjs task as grunt serverall task does the same thing if only working on javascript
  • Make grunt server task run all watch tasks just like with grunt serverall.
  • Move all linting to it's own grunt task which is run in circle and travis as well.
  • Minor html formatting

'connect:server',
'watch:javascript'
grunt.registerTask('serverall', [
'server'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwardoparearyee so server and serverall now do the same thing, do we still need both?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they do, I was thinking the same but wasn't sure whether to keep it because we have gotten so used to using serverall. But yeah think we should drop serverall if your okay with it as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with dropping it, I like the simplification of just having one server task 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally meant for grunt server as a way of refreshing the server and not running test incase it took ages to refresh due to hundreds of test but due to the way i've broken up the watch task it's not really possible anymore without running certain tasks unnecessarily. I'll remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesjwarren should be fixed now

@jamesjwarren
Copy link
Member

👍

@edoparearyee
Copy link
Collaborator Author

@jamesjwarren made one more change, updated the name of test commands to grunt test:unit:development, grunt test:unit:production and grunt test:e2e, let me know what you think

@jamesjwarren
Copy link
Member

@edwardoparearyee yeh, thats cool 👍

edoparearyee added a commit that referenced this pull request Nov 12, 2015
@edoparearyee edoparearyee merged commit e49ea65 into develop Nov 12, 2015
@edoparearyee edoparearyee deleted the feature/update-gruntfile branch November 12, 2015 10:47
@edoparearyee edoparearyee mentioned this pull request Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants