-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Update gruntfile #36
Conversation
'connect:server', | ||
'watch:javascript' | ||
grunt.registerTask('serverall', [ | ||
'server' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edwardoparearyee so server and serverall now do the same thing, do we still need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they do, I was thinking the same but wasn't sure whether to keep it because we have gotten so used to using serverall
. But yeah think we should drop serverall
if your okay with it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with dropping it, I like the simplification of just having one server task 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally meant for grunt server
as a way of refreshing the server and not running test incase it took ages to refresh due to hundreds of test but due to the way i've broken up the watch task it's not really possible anymore without running certain tasks unnecessarily. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesjwarren should be fixed now
👍 |
@jamesjwarren made one more change, updated the name of test commands to |
@edwardoparearyee yeh, thats cool 👍 |
Feature: Update gruntfile
This PR includes the following updates the build process:
qualified-headings
options inlesslint
task as bootstrap doesn't follow this rule.style
tag inhtmllint
for use in modules prototype pages.grunt watch
tasks into smaller tasks so only the nessesary tasks are called when updating files..csslintrc
and.htmllint
files into project root likejshintrc
so easier to find.modules
folder as wellgrunt serverjs
task asgrunt serverall
task does the same thing if only working on javascriptgrunt server
task run all watch tasks just like withgrunt serverall
.