Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for line continuations #10

Open
vilya opened this issue Oct 10, 2019 · 0 comments
Open

Support for line continuations #10

vilya opened this issue Oct 10, 2019 · 0 comments

Comments

@vilya
Copy link

vilya commented Oct 10, 2019

OBJ allows line continuations: if you put a backslash at the end of a line, parsing is supposed to continue on the next line as if it were part of the same line (Source: https://www.fileformat.info/format/wavefrontobj/egff.htm). fast_obj doesn't handle this properly and can seg fault when parsing files with line continuations.

It's pretty rare to encounter this in the wild and handling it properly would likely have a performance impact so maybe it's not actually worth supporting, but I thought it was at least worth mentioning.

Either way, thanks for making fast_obj available - it's a really nice little library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant