Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Dockerfile to containerise the tool #173

Closed
pavelexpertov opened this issue Oct 31, 2019 · 5 comments · Fixed by #226
Closed

Add a Dockerfile to containerise the tool #173

pavelexpertov opened this issue Oct 31, 2019 · 5 comments · Fixed by #226

Comments

@pavelexpertov
Copy link

I really like the tool, but my colleagues tend to not have npm/yarn/nvm installed since they aren't JavaScript developers.

Thus, I was thinking to make a pull requests with a simple Dockerfile and it will be up to you to publish an image to registry or not.

@pavelexpertov
Copy link
Author

Hey @thlorenz , I am about to write a Dockerfile for my team, but I am interested to contribute it to the repository for others to use. But I would like to receive confirmation that you would allow me to provide a pull request for this to happen.

@PeterDaveHello
Copy link
Collaborator

Related issue: #221 / pull request: #222

I just got a personal Docker image for doctoc here if you'd like to use an existing and working image:

@thlorenz
Copy link
Owner

@pavelexpertov do the images that @PeterDaveHello provided help you?

If so @PeterDaveHello would you mind adding that info to the Readme via a PR please?

@PeterDaveHello
Copy link
Collaborator

Sure I can add it 👍

@PeterDaveHello
Copy link
Collaborator

PR sent: #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants