Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linux LLVM paths #18

Merged
merged 1 commit into from
Aug 28, 2021
Merged

chore: fix linux LLVM paths #18

merged 1 commit into from
Aug 28, 2021

Conversation

cipherchabon
Copy link
Contributor

On my machine I had to add a new path to locate the LLVM.
To locate the path I used the following command:

$ find /usr -iname "libclang.so" -print
/usr/lib/llvm-6.0/lib/libclang.so

I leave a link to the issue as a reference of the problem I had and the solution.

#14 (comment)

@thlorenz
Copy link
Owner

I assume this works more reliably than just passing the folders (even though I assume the issue actually lies with ffigen).
With all the tests passing in CI (for Ubuntu) it looks like nothing broke either, so just gonna merge this.

Thanks for the fix @cypherchabon

@thlorenz thlorenz merged commit c1a2e0a into master Aug 28, 2021
@thlorenz thlorenz deleted the fix-linux-llvm-paths branch August 28, 2021 00:01
@thlorenz
Copy link
Owner

@cypherchabon just for future reference, please try to create the branch and push commits to your fork instead directly to this repo for now. Otherwise we might get confused with numerous branches by numerous developers here.
You can then create a PR from your fork to this repo.

@cipherchabon
Copy link
Contributor Author

For a moment I thought about doing it through a fork, but then I remembered that you had asked us to please not fork. When in doubt I should have asked, but I'll do it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants