Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and AbstractAlgebra and Nemo compats #1208

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

lgoettgens
Copy link
Contributor

cc @thofma

@lgoettgens
Copy link
Contributor Author

Let's see what broke in Hecke

@lgoettgens
Copy link
Contributor Author

Most errors looks like Nemocas/AbstractAlgebra.jl#1424.
I can make a doctest fix run locally for that. Unless you are already doing that :)

@thofma
Copy link
Owner

thofma commented Sep 13, 2023

Should be fixed now

to fix `identity_map` printing
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.15% 🎉

Comparison is base (727918f) 74.40% compared to head (1357384) 74.56%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
+ Coverage   74.40%   74.56%   +0.15%     
==========================================
  Files         346      346              
  Lines      110746   110750       +4     
==========================================
+ Hits        82403    82577     +174     
+ Misses      28343    28173     -170     
Files Changed Coverage Δ
src/Misc/Matrix.jl 75.49% <ø> (ø)
src/QuadForm/Quad/ZLattices.jl 93.81% <ø> (+0.27%) ⬆️
src/QuadForm/Torsion.jl 91.06% <ø> (+0.11%) ⬆️
src/QuadForm/Types.jl 81.15% <ø> (ø)
src/GrpAb/GrpAbFinGen.jl 81.14% <80.00%> (+0.13%) ⬆️
src/GrpAb/SubgroupEnum.jl 83.87% <100.00%> (+0.07%) ⬆️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens closed this Sep 13, 2023
@lgoettgens lgoettgens reopened this Sep 13, 2023
@lgoettgens lgoettgens closed this Sep 14, 2023
@lgoettgens lgoettgens reopened this Sep 14, 2023
@thofma thofma merged commit 1cf978a into thofma:master Sep 14, 2023
33 of 44 checks passed
@lgoettgens lgoettgens deleted the patch-1 branch September 14, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants