Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove many calls to *cat(::Vector{...}) #1253

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

lgoettgens
Copy link
Contributor

src/conjugates.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d8aa190) 74.55% compared to head (f7611e1) 74.56%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   74.55%   74.56%           
=======================================
  Files         346      346           
  Lines      110993   110993           
=======================================
+ Hits        82756    82765    +9     
+ Misses      28237    28228    -9     
Files Coverage Δ
src/AlgAssAbsOrd/LocallyFreeClassGroup.jl 92.30% <100.00%> (ø)
src/GenOrd/Ideal.jl 78.32% <100.00%> (ø)
src/GrpAb/Map.jl 79.78% <100.00%> (ø)
src/Map/GrpAb.jl 80.23% <100.00%> (ø)
src/Misc/Poly.jl 62.11% <100.00%> (ø)
src/NumFieldOrd/NfOrd/norm_eqn.jl 76.00% <100.00%> (ø)
src/GenOrd/GenOrd.jl 78.30% <50.00%> (ø)
src/GenOrd/Types.jl 88.78% <0.00%> (ø)
src/LocalField/neq.jl 68.37% <50.00%> (-0.86%) ⬇️
src/Misc/PseudoPolynomial.jl 9.72% <0.00%> (ø)
... and 4 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 5140ace into thofma:master Oct 20, 2023
13 of 16 checks passed
@lgoettgens lgoettgens deleted the lg/cat branch October 20, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants