Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not write PEM inside extension's directory #101

Closed
ahwayakchih opened this issue Mar 30, 2019 · 0 comments · Fixed by #104
Closed

Do not write PEM inside extension's directory #101

ahwayakchih opened this issue Mar 30, 2019 · 0 comments · Fixed by #104

Comments

@ahwayakchih
Copy link
Collaborator

Writing private key file inside extension's directory is just an accident waiting to happen ;).

Maybe it would be safer to default to creating it next to the directory instead?
ahwayakchih added a commit to ahwayakchih/crx that referenced this issue Apr 7, 2019
@ahwayakchih
fix: create private key file outside extension directory by default
9aa563f 
BREAKING CHANGE: if no `--private-key` is passed, module will look for `extension/../key.pem` instead of `extension/key.pem`. It should discourage risky behavior of keeping private key file inside extension's directory (the one that is ZIPped and packed into CRX file).

fixes: thom4parisot#101
@ahwayakchih ahwayakchih mentioned this issue Apr 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: create private key file outside extension directory by default ahwayakchih/crx
1 participant
@ahwayakchih