Windows Compatibility #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ncp dependency and implement recursive copy with ncp Use path join for portability Use path join in test.
New dependencies: * wrench - for easy recursive file operations * archiver - tool to zip files * buggerstream - in memory data stream to write archiver data Removed dependencies: * (*nix) operating system * zip command The rest of the path joins using + were found and fixed.
Remove zip dependency Update example javascript to use cross-platform join rather than plus to concat directories
Calling keygen from the command line was broken, because cb() is filled in by commander but it is not a function Rename path.exists to fs.exists to remove deprecated warning
|
thanks, @ADotOut! now in in npm as v.04. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added node dependencies:
Archiver - Used for zipping
BufferStream - Used to stream the output of the archiver into memory
Wrench - No hassle recursive file operations
Removed dependencies:
*NIX operating system
zip command line utility
I had to upgrade the node min version from 0.6.x to 0.7.x because of the new "fs" operations. I have tested these changes (using text/index.js) on both Windows 7 and Ubuntu 12.04. Both were able to produce a crx file that could be installed in Chrome. I upgraded the package from 0.2.9 -> 0.3.0, because this is a pretty big change and it will break people using very old versions of node.
Other misc. things:
Keygen from the command line wasn't working because commander doesn't provide a callback as the second parameter - this is fixed
I changed path.exists to fs.exists to get rid of a deprecated warning
I added "manifest_version": 2 to your example extension - this is required in the latest versions of chrome
Let me know if you need me to change anything, or if you see any problems.