-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eMagLS for EMA and extensive project updates #1
Conversation
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(update example script to download data on demand) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(update example script to download data on demand) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(reintroduce length limitation of the rendered SMA recording) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…he MagLS diffuseness constraint Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…LS and eMagLS2 filters (also add the respective reference results) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…t provided reference Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
… parameter Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…tional parameter (see `testEMagLs.m` for a usage example) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(update file names of respective reference results) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…rove computation time Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(fix to yield real or complex filters depending on the basis type) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…lters against the provided reference Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ations (results in neglectable maximum normalized absolute difference of 1e-15) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(results in neglectable maximum normalized absolute difference of 1e-16) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…rations (results in neglectable maximum normalized absolute difference of 1e-15) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…erations (results in neglectable maximum normalized absolute difference of 1e-14) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…tions Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ffs()` from Array-Response-Simulator (therefore also remove own implementations of spherical hankel and bessel functions) (this causes the resulting eMagLS and eMagLS2 rendering filters to be slightly different at 0 Hz and the Nyquist bin) (therefore the reference for eMagLS and eMagLS2 rendering filters are updated for verification) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
… easily Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ignal parts (may occur for complex SH basis functions) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…t resolution Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ystem-dependent differences in resulting rendering filters" This reverts commit 4b8a3f4 Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(therefore the reference for the rendering filters are updated for verification) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…n after calculation Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ers against the reference by default Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ess constraint with "complex" SH conventions (this is not implemented yet) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ters after calculation Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ally removed before) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…rameters correctly Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…arameters (therefore the default values "@Getsh" and "real" of the rendering filter functions will be used) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…arameters (therefore the default values "@Getsh" and "real" of the rendering filter functions will be used) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
(therefore the default value "false" of the rendering filter functions will be used) Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…ownload a large ZIP file when executing the example for the first time Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
…o not download a large ZIP file when executing the example for the first time Signed-off-by: HaHeho <hannes.helmholz@chalmers.se>
PR is merged. :) @thomasdeppisch, I think only you can rename the default branch of the repository to Afterward, I will add a few release tags and perform the remaining steps. |
Great, many thanks for your efforts! :) I'll look into the renaming now |
I just renamed the master to main and cloned the repo and everything works as expected :) |
Nice. Yes and EMA rendering example would be nice to have as well. We will need a source audio recording for that. Ideally, we could even have the same scenario captured with an SMA and an EMA. Maybe something from the latest TU Berlin data set? |
That’s a great idea! |
TODOs before merge:
getEMagLsFiltersEMAinSH()
)getMagLsArrayDiffuseFilter.m
andgetMagLsSphericalHeadFilter.m
functionsshDefinition
andshFunction
parameters in all filter functionsshDefinition
andshFunction
parameters (i.e. use the default values)applyDiffusenessConst
parameterapplyDiffusenessConst
parameter (i.e. use the default value)TODOs after merge:
master
intomain
branchmain
URL