This repository has been archived by the owner on Aug 14, 2022. It is now read-only.
Fix pdf-view focus #416
Merged
Fix pdf-view focus #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be awesome to have some tests for this both to ensure we aren't breaking anything and also to guard against future regressions, but I'm not sure it's worth the effort right now. Would likely involve a fair bit of orchestration and pane wizardry ✨ |
|
I agree. UI tests would be awesome but seem like a lot of work. I am planning on updating the change log with credit to the issue creator since he did all the work, FYI. |
Yeah, was just about to suggest that 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect
openInBackgroundsetting by saving and re-activating previous pane. Resolves #413