Skip to content
This repository has been archived by the owner on Aug 14, 2022. It is now read-only.

Added qpdfview with synctex #442

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Added qpdfview with synctex #442

merged 3 commits into from
Nov 22, 2017

Conversation

skidpa
Copy link
Contributor

@skidpa skidpa commented Nov 17, 2017

Hi i created a opener for qpdfview with synctex and appendend the package.json file with what i think is the appropriate information. It's really just a modified zathura-opener

this is my first time contributing so i might have made a fool of my self though.

const qpdfviewPath = atom.config.get('latex.qpdfviewPath')
const args = [
`--unique`,
`${filePath}#src:${texPath}:${lineNumber}:0`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to quote the file argument in case there are spaces in the path.

@yitzchak
Copy link
Collaborator

Thank you for submitting the PR. We really appreciate any and all code submissions!

So far I just see the issue regarding quoting the file path argument, which I've added a line comment for that.

@thomasjo Can you take a look when you get a chance?

@skidpa
Copy link
Contributor Author

skidpa commented Nov 18, 2017

Your are absolutely right. I shamelessly overlooked that part, it should be
"${filePath}"#src:"${texPath}":${lineNumber}:0
or
"${filePath}#src:${texPath}":${lineNumber}:0
both seems to work fine on my system with spases in the paths's and without i guess its mostly a matter of which way you preferr.
I've fixed it and pushed the first option to my repo anything else i should do?

@thomasjo
Copy link
Owner

Thanks for adding this! 🥇

@thomasjo thomasjo merged commit ffed8d4 into thomasjo:master Nov 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants