New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating game.js to ES6 #151

Open

lucasrafaldini wants to merge 1 commit into thomaspark:gh-pages from lucasrafaldini:patch-1

lucasrafaldini commented Oct 4, 2019

Replacing empty named functions by ES6's arrow functions


          Updating game.js to ES6

3e57213

Replacing empty named functions by ES6's arrow functions

Owner

thomaspark commented Oct 5, 2019

Hey @lucasrafaldini, thanks for the PR.

We have take care replacing functions with arrow functions because there are several places within the functions where this is used, and this change will affect their values. See: https://stackoverflow.com/questions/31095710/methods-in-es6-objects-using-arrow-functions

We can keep functions as is, or also replace this with game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet