Path with a complex filter match only the first occurrence #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- navigate return a list of sub-schemas - `applyRemoveOperation` and `applyAddOrReplaceOperation` adapted to the new signature (and logic)
This reverts commit e8354a6.
"REPLACE: replace on multiValued objects without complete path"
thomaspoignant
previously approved these changes
Nov 30, 2023
|
Oh i hadn't noticed those comments, i will remove them as soon as i can. |
|
Kudos, SonarCloud Quality Gate passed!
|
thomaspoignant
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To solve this bug i changed slightly the logic of
navigate,applyRemoveOperation()andapplyRemoveOperation()to work with multiple paths (arrays of paths) instead of a single one.I've added some test for checking the cases discussed in the issue.
In the new code there is FIXME describing a possible unwanted error, but it should be only caused by some schemas out of the SCIM standard (with depth greater than 1). If it is ok i can remove the comment otherwise i can try to fix it
Changes include
Closes issue(s)
Resolve #503
Checklist